Repository navigation
Single-reviewer approval gate and clearer awaiting-review status - #4639
Merged
Merged
Conversation
…iew as action_required Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f280c771-d797-4eb1-a96f-ada49c076e86
Contributor
🚦 Submission status: 👀 Ready for reviewRisk tier: Why this tier
Automated checks
Review
Commands
Updated for |
Contributor
|
🟡 Contributor Reputation Check: MEDIUM risk
Maintainers: please review this contributor before merging. |
github-actions
Bot
added
needs-review:MEDIUM
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
It weakens a security-sensitive review policy and therefore requires explicit maintainer review.
1 open finding
What changed in this PR
This PR reduces high-risk approval requirements and distinguishes review-waiting states from automation failures.
Changes:
- Requires one core-maintainer approval for high-risk PRs.
- Publishes
action_requiredwhen only approval is missing. - Updates tests and maintainer documentation.
| File | Description |
|---|---|
.github/risk-tiers.yml |
Reduces high-risk approvals to one. |
eng/submission-gate.mjs |
Adds conclusion-selection logic. |
eng/submission-gate.test.mjs |
Tests approval and conclusion behavior. |
docs/maintainers/submission-gate.md |
Documents the revised policy. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
| const fields = pending | ||
| ? { status: "in_progress", output } | ||
| : { status: "completed", conclusion: evaluation.passed ? "success" : "failure", completed_at: new Date().toISOString(), output }; | ||
| : { status: "completed", conclusion: gateConclusion(evaluation), completed_at: new Date().toISOString(), output }; |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.mainbranch for this pull request.Description
Only one maintainer reviews, so the two-approval requirement is dropped and the gate result is made clearer when a PR is just waiting on review.
merge-risk:highnow needs 1 approval from a core maintainer (or an admin/maintain user while the core pool is empty), down from 2. Low and medium already needed 1.submission-gatecheck now concludesaction_requiredinstead offailurewhen the only blocker is a missing approval. It still blocks merging as a required check, but reads as "waiting for a reviewer" rather than a broken workflow. Failed checks, infrastructure failures, pending checks and requested changes still reportfailure. Implemented via a newgateConclusion()ineng/submission-gate.mjs.docs/maintainers/submission-gate.md) and tests updated.Validation:
node --test eng/submission-gate.test.mjspassed (48/48).npm run buildwas not run.Type of Contribution
Additional Notes
The Submission Gate workflow run itself is unchanged; only the published
submission-gatecheck conclusion differs.By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.