Skip to content

Optimize catalog filter membership checks - #4448

Merged
aaronpowell merged 3 commits into
github:mainfrom
emilus512-cmyk:perf/catalog-filter-lookup
Oct 7, 2026
Merged

aaronpowell merged 3 commits into
github:mainfrom
emilus512-cmyk:perf/catalog-filter-lookup

Conversation

@emilus512-cmyk

Copy link
Copy Markdown
Contributor

Summary

This PR reduces repeated array membership scans in the agent and plugin catalog filters by converting the per-item lookups to Sets before evaluating selected filters.

Why

The catalog filter paths were repeatedly doing includes() against arrays for each item in the list. On larger catalogs, that turns filter evaluation into a quadratic-style cost for each render.

Changes

  • Use Set-based membership checks in AgentsCatalog
  • Use Set-based membership checks in PluginsCatalog

Validation

  • Ran the website data generation build pipeline successfully
  • Verified the Astro site build succeeds after generating the JSON metadata

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:medium — New or substantially changed resource without privileged execution
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access.

Why this tier
  • Changes 73 lines (low-risk limit is 40)

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s)
  • No staffed reviewer pool owns these files yet; any reviewer with write access counts as the domain reviewer.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for 9849554 · gate run · This comment is maintained automatically — see submission gate docs.

Copilot AI added 2 commits October 3, 2026 05:12
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@aaronpowell

Copy link
Copy Markdown
Contributor

/rerun-checks

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🔁 /rerun-checks for 9849554

No failed or incomplete checks to re-run.

  • PR Duplicate Check waiting for a maintainer to approve workflow runs.
  • Contributor Reputation Check waiting for a maintainer to approve workflow runs.
  • Label PR Intent waiting for a maintainer to approve workflow runs.
  • Check Spelling waiting for a maintainer to approve workflow runs.
  • PR Quality Signal Review waiting for a maintainer to approve workflow runs.
  • Deploy preview website to GitHub Pages waiting for a maintainer to approve workflow runs.
  • Check Line Endings waiting for a maintainer to approve workflow runs.
  • Submission Gate waiting for a maintainer to approve workflow runs.

The status comment updates when the checks finish.

@github-actions github-actions Bot added website-update PR touches website content or code ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Oct 7, 2026
@aaronpowell
aaronpowell merged commit 0052323 into github:main Oct 7, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk:medium ready-for-review Submission passed intake validation and is ready for maintainer review website-update PR touches website content or code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants