Repository navigation
main into v3 for new release - #282
Open
abdulahmad307 wants to merge 10 commits into
Open
abdulahmad307 wants to merge 10 commits into
abdulahmad307 wants to merge 10 commits into
Conversation
Bumps the bundler-minor-and-patch group in /sites/site-with-errors with 1 update: [jekyll-feed](https://github.com/jekyll/jekyll-feed). Updates `jekyll-feed` from 0.17.0 to 0.18.0 - [Release notes](https://github.com/jekyll/jekyll-feed/releases) - [Changelog](https://github.com/jekyll/jekyll-feed/blob/master/History.markdown) - [Commits](jekyll/jekyll-feed@v0.17.0...v0.18.0) --- updated-dependencies: - dependency-name: jekyll-feed dependency-version: 0.18.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: bundler-minor-and-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…e-with-errors in the bundler-minor-and-patch group (#280) Bumps the bundler-minor-and-patch group in /sites/site-with-errors with 1 update: [jekyll-feed](https://github.com/jekyll/jekyll-feed). Updates `jekyll-feed` from 0.17.0 to 0.18.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/jekyll/jekyll-feed/releases">jekyll-feed's releases</a>.</em></p> <blockquote> <h2>v0.18.0</h2> <h3>Security</h3> <ul> <li>Escape <code>xml:lang</code> values and CDATA terminators in the feed (GHSA-3gx8-pqcm-38hw, <a href="https://redirect.github.com/jekyll/jekyll-feed/issues/396">#396</a>)</li> </ul> <h3>Development Fixes</h3> <ul> <li>Upgrade to Rake 13 to fix master (<a href="https://redirect.github.com/jekyll/jekyll-feed/issues/381">#381</a>)</li> <li>feat(CI): Add Ruby 3.2/3.3 to the test matrix (<a href="https://redirect.github.com/jekyll/jekyll-feed/issues/402">#402</a>)</li> <li>Fix style offenses (<a href="https://redirect.github.com/jekyll/jekyll-feed/issues/414">#414</a>)</li> </ul> <h3>Documentation</h3> <ul> <li>Fix typos in Readme (<a href="https://redirect.github.com/jekyll/jekyll-feed/issues/384">#384</a>)</li> </ul> <h3>Minor Enhancements</h3> <ul> <li>Icon and logo support with simple tests (<a href="https://redirect.github.com/jekyll/jekyll-feed/issues/412">#412</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/jekyll/jekyll-feed/blob/master/History.markdown">jekyll-feed's changelog</a>.</em></p> <blockquote> <h2>0.18.0 / 2026-09-29</h2> <h3>Security</h3> <ul> <li>Escape <code>xml:lang</code> values and CDATA terminators in the feed (GHSA-3gx8-pqcm-38hw, <a href="https://redirect.github.com/jekyll/jekyll-feed/issues/396">#396</a>)</li> </ul> <h3>Development Fixes</h3> <ul> <li>Upgrade to Rake 13 to fix master (<a href="https://redirect.github.com/jekyll/jekyll-feed/issues/381">#381</a>)</li> <li>feat(CI): Add Ruby 3.2/3.3 to the test matrix (<a href="https://redirect.github.com/jekyll/jekyll-feed/issues/402">#402</a>)</li> <li>Fix style offenses (<a href="https://redirect.github.com/jekyll/jekyll-feed/issues/414">#414</a>)</li> </ul> <h3>Documentation</h3> <ul> <li>Fix typos in Readme (<a href="https://redirect.github.com/jekyll/jekyll-feed/issues/384">#384</a>)</li> </ul> <h3>Minor Enhancements</h3> <ul> <li>Icon and logo support with simple tests (<a href="https://redirect.github.com/jekyll/jekyll-feed/issues/412">#412</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/jekyll/jekyll-feed/commit/61a0447d10cb263b639c8fd13468676c278f89a6"><code>61a0447</code></a> Merge pull request <a href="https://redirect.github.com/jekyll/jekyll-feed/issues/431">#431</a> from jekyll/escape-entry-lang</li> <li><a href="https://github.com/jekyll/jekyll-feed/commit/2215b0e2fab0b64a6020dffd1a0c946a416e71ca"><code>2215b0e</code></a> Release 0.18.0</li> <li><a href="https://github.com/jekyll/jekyll-feed/commit/b4225de025ed0ad9a4549315f0a310aa6f15e61c"><code>b4225de</code></a> Escape entry language</li> <li><a href="https://github.com/jekyll/jekyll-feed/commit/43cc5d51e30b59ab8d8ba970e42c8c437e2b233f"><code>43cc5d5</code></a> Update history to reflect merge of <a href="https://redirect.github.com/jekyll/jekyll-feed/issues/414">#414</a> [ci skip]</li> <li><a href="https://github.com/jekyll/jekyll-feed/commit/7aa1e69b76806e56bd37e129bd37cb38a974fd3c"><code>7aa1e69</code></a> Fix style offenses (<a href="https://redirect.github.com/jekyll/jekyll-feed/issues/414">#414</a>)</li> <li><a href="https://github.com/jekyll/jekyll-feed/commit/1f3d80ff19afedc6e98c75d89505b7809af5bd70"><code>1f3d80f</code></a> Update history to reflect merge of <a href="https://redirect.github.com/jekyll/jekyll-feed/issues/412">#412</a> [ci skip]</li> <li><a href="https://github.com/jekyll/jekyll-feed/commit/f0ccb2f306bf8c8e591c6dacf7fa33f7a27db94c"><code>f0ccb2f</code></a> Icon and logo support with simple tests (<a href="https://redirect.github.com/jekyll/jekyll-feed/issues/412">#412</a>)</li> <li><a href="https://github.com/jekyll/jekyll-feed/commit/f321e1cd8115599340fb3668edab1ae768c25927"><code>f321e1c</code></a> Update history to reflect merge of <a href="https://redirect.github.com/jekyll/jekyll-feed/issues/402">#402</a> [ci skip]</li> <li><a href="https://github.com/jekyll/jekyll-feed/commit/d9f04a734b497d2cbb699c429ca1fb4758d98956"><code>d9f04a7</code></a> feat(CI): Add Ruby 3.2/3.3 to the test matrix (<a href="https://redirect.github.com/jekyll/jekyll-feed/issues/402">#402</a>)</li> <li><a href="https://github.com/jekyll/jekyll-feed/commit/7d9c3a4c215ee37d1db28e48126096a0e447c457"><code>7d9c3a4</code></a> History.markdown: Fix release date of 0.9.3</li> <li>Additional commits viewable in <a href="https://github.com/jekyll/jekyll-feed/compare/v0.17.0...v0.18.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details>
Co-authored-by: abdulahmad307 <204748719+abdulahmad307@users.noreply.github.com>
Co-authored-by: abdulahmad307 <204748719+abdulahmad307@users.noreply.github.com>
Co-authored-by: abdulahmad307 <204748719+abdulahmad307@users.noreply.github.com>
Changed originalUrl from optional to required in the Solution type.
Co-authored-by: abdulahmad307 <204748719+abdulahmad307@users.noreply.github.com>
When we perform a scan, we may end up on a different url than the
intended one (due to redirects for login or otherwise). The 'find'
action only adds the scanned url (the url we land on) to the findings.
There are situations where we need to preserve the original/intended
url.
The ideal approach would be to call the existing 'url' field:
'scannedUrl', and populating the 'url' field with the original/intended
url. The problem with this approach is it't not backward compatible.
Existing codebases would have to account for this change. Instead, I
decided to introduce a new 'originalUrl' field that captures the
intended url that was supposed to be scanned. This leaves the existing
url field as-is and doesnt disrupt existing codebases.
### Copilot summary
Findings only carried the URL the page ended up on (`page.url()`). If
the page redirected, for example to a login page, the URL we were asked
to scan was lost. This PR records that URL on every finding as
`originalUrl`.
- **`findForUrl.ts`**: `addFinding` now sets `originalUrl: url`, where
`url` is the configured URL passed to `page.goto`. It is the last
property in the `findings.push({...})` call, so a plugin-supplied
`originalUrl` can't overwrite it.
- **`types.d.ts`**: `Finding` gains an optional `originalUrl?: string`.
- **Tests**: a new case in `findForUrl.test.ts` checks that findings
carry the configured URL.
```ts
findings.push({...findingData, screenshotId, originalUrl: url})
```
`Finding.url` is unchanged. It is still the post-redirect URL from
`page.url()`.
abdulahmad307
requested review from
accessibility-bot
and
a max review from Copilot
October 15, 2026 20:14
JoyceZhu
approved these changes
Oct 15, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Publishing to the shared v3 release branch warrants maintainer sign-off, especially with the unresolved cached-finding type mismatch.
1 open finding
What changed in this PR
Releases #281’s original-URL tracking on v3, preserving the existing post-redirect url behavior.
Changes:
- Adds
originalUrlto findings while preserving plugin input compatibility. - Updates finding types and URL-preservation tests.
- Refreshes the test site’s Ruby dependencies.
| File | Description |
|---|---|
| tests/types.d.ts | Adds original-URL metadata to test types. |
| tests/site-with-errors.test.ts | Checks cached findings contain originalUrl. |
| sites/site-with-errors/Gemfile.lock | Updates locked dependencies. |
| sites/site-with-errors/Gemfile | Raises the jekyll-feed version constraint. |
| .github/actions/find/tests/findForUrl.test.ts | Tests configured-URL preservation. |
| .github/actions/find/src/types.d.ts | Separates finding output and input types. |
| .github/actions/find/src/pluginManager/types.ts | Updates plugin callback input types. |
| .github/actions/find/src/findForUrl.ts | Records the configured URL on findings. |
| .github/actions/file/src/types.d.ts | Adds original-URL metadata to filing types. |
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| category?: FindingCategory | ||
| ruleId?: string | ||
| url: string | ||
| originalUrl: string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
releasing the new change from this PR.
all workflows have passed using the main branch.