Skip to content

ref(admin): Use scraps components in Provision Subscription modal - #131030

Draft
sentry-junior[bot] wants to merge 1 commit into
masterfrom
ref/gsadmin-provision-subscription-scraps
Draft

sentry-junior[bot] wants to merge 1 commit into
masterfrom
ref/gsadmin-provision-subscription-scraps

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

The admin Provision Subscription modal no longer uses legacy Bootstrap classes, so React code depends less on the global static/css stylesheet. Field labels and help text use Stack and Text (<label htmlFor> is unchanged), the error message uses a danger Alert, and Cancel and Submit are scraps Buttons in the modal Footer. The two field wrappers had the same markup, so they are now one FormFieldWrapper. Selects still get their accessible name from the aria-label on react-select.

The footer is outside the <form>, so Submit points at it with form="provision-subscription-form". Enter in a field still submits the form. Switches now sit under their labels, not inline after them, like every other field. Nothing else changes in behavior.

No static/css changes: Django templates and crispy-forms still render control-label, help-block, btn* and alert*. .control-group is also used by customIgnoreDurationModal.tsx, which is being converted in a separate PR. Delete that rule once both PRs land.

Changed

Location Before After
Customers › customer details › Customers Actions › Provision Subscription Provision Subscription before Provision Subscription after
Customers › customer details › Customers Actions › Provision Subscription, error Provision Subscription, error before Provision Subscription, error after

via malachi.

--

View Session [Sentry]

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 13, 2026
Replace the Bootstrap control-group/control-label/help-block markup, the alert-error div, and the btn/modal-footer buttons with Stack, Text, Alert, Button, and the modal Footer. The select and input field wrappers were identical, so they are now one wrapper.

Co-Authored-By: Malachi Willey <malachi.willey@sentry.io>

This branch was successfully deployed

1 active deployment
Preview — 6b6687dc Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants