Repository navigation
ref(admin): Use scraps components in Provision Subscription modal - #131030
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Replace the Bootstrap control-group/control-label/help-block markup, the alert-error div, and the btn/modal-footer buttons with Stack, Text, Alert, Button, and the modal Footer. The select and input field wrappers were identical, so they are now one wrapper. Co-Authored-By: Malachi Willey <malachi.willey@sentry.io>
sentry-junior
Bot
force-pushed
the
ref/gsadmin-provision-subscription-scraps
branch
from
November 13, 2026 19:56
7eb24bc to
6b6687d
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admin Provision Subscription modal no longer uses legacy Bootstrap classes, so React code depends less on the global
static/cssstylesheet. Field labels and help text useStackandText(<label htmlFor>is unchanged), the error message uses a dangerAlert, and Cancel and Submit are scrapsButtons in the modalFooter. The two field wrappers had the same markup, so they are now oneFormFieldWrapper. Selects still get their accessible name from thearia-labelon react-select.The footer is outside the
<form>, so Submit points at it withform="provision-subscription-form". Enter in a field still submits the form. Switches now sit under their labels, not inline after them, like every other field. Nothing else changes in behavior.No
static/csschanges: Django templates and crispy-forms still rendercontrol-label,help-block,btn*andalert*..control-groupis also used bycustomIgnoreDurationModal.tsx, which is being converted in a separate PR. Delete that rule once both PRs land.Changed
via malachi.
--
View Session [Sentry]