Skip to content

nar(ref): Remove visibility-explore-view flag from backend code - #130931

Open
narsaynorath wants to merge 5 commits into
nar/feat/explore-remove-feature-flagfrom
nar/ref/explore-remove-backend-feature-gate
Open

narsaynorath wants to merge 5 commits into
nar/feat/explore-remove-feature-flagfrom
nar/ref/explore-remove-backend-feature-gate

Conversation

@narsaynorath

Copy link
Copy Markdown
Member

Removes the backend feature flag checks for the visibility explore flag

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 12, 2026
@narsaynorath narsaynorath changed the title nar(ref): Remove visibility-explore-view from backend code nar(ref): Remove visibility-explore-view flag from backend code Nov 12, 2026
@narsaynorath
narsaynorath force-pushed the nar/ref/explore-remove-backend-feature-gate branch from 87a3061 to 52fb595 Compare November 12, 2026 21:04
@narsaynorath
narsaynorath marked this pull request as ready for review November 12, 2026 21:19
@narsaynorath
narsaynorath requested review from a team as code owners November 12, 2026 21:19
actor=request.user,
)
)
return True

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to remove has_feature altogether if it just always return True?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that and originally had it remove everything, but I felt like it was a good pattern to keep around to be consistent with the early return if for some reason access wasn't there.

But now that I think about it again, maybe we just remove it because there's no point keeping the stubs for structural reasons if they actually mean nothing

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants