Repository navigation
ref(typing): Let feature and search helpers take a service account - #129423
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
gricha
force-pushed
the
ref/sa-narrow-widen
branch
from
November 1, 2026 04:24
8e185f5 to
94da59d
Compare
Contributor
Sentry Snapshot Testing
|
gricha
force-pushed
the
ref/sa-narrow-widen
branch
from
November 1, 2026 04:57
94da59d to
70e65f0
Compare
gricha
force-pushed
the
ref/sa-narrow-widen
branch
2 times, most recently
from
November 2, 2026 20:14
4767324 to
df7da88
Compare
gricha
force-pushed
the
ref/sa-narrow-widen
branch
from
November 2, 2026 20:29
df7da88 to
244a554
Compare
gricha
force-pushed
the
ref/sa-narrow-widen
branch
from
November 2, 2026 20:33
244a554 to
36d2629
Compare
gricha
force-pushed
the
ref/sa-narrow-widen
branch
from
November 2, 2026 20:35
36d2629 to
5e7b8bf
Compare
gricha
force-pushed
the
ref/sa-narrow-widen
branch
from
November 2, 2026 21:03
5e7b8bf to
b020cd8
Compare
gricha
force-pushed
the
ref/sa-narrow-widen
branch
from
November 2, 2026 21:10
b020cd8 to
9fe847b
Compare
gricha
marked this pull request as ready for review
November 2, 2026 21:13
gricha
force-pushed
the
ref/sa-narrow-widen
branch
from
November 3, 2026 04:03
b24fa19 to
7a16ca8
Compare
gricha
force-pushed
the
ref/sa-narrow-widen
branch
from
November 3, 2026 04:41
7a16ca8 to
2774099
Compare
cvxluo
approved these changes
Nov 3, 2026
gricha
force-pushed
the
ref/sa-narrow-widen
branch
from
November 3, 2026 19:53
2774099 to
1c0a0b7
Compare
gricha
force-pushed
the
ref/sa-narrow-widen
branch
2 times, most recently
from
November 3, 2026 20:09
514001f to
f653947
Compare
gricha
force-pushed
the
ref/sa-narrow-widen
branch
from
November 3, 2026 20:51
f653947 to
6cfb62f
Compare
is_provider_enabled, the preprod quota checks, investigation action kinds' cannot_apply_reasons, parse_user_value and store_issue_last_defaults now take a RequestPrincipal. They only forward the caller to features.has(), ignore it, or already check has_user(), so this is type-only.
gricha
force-pushed
the
ref/sa-narrow-widen
branch
from
November 3, 2026 21:10
6cfb62f to
c66dead
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_provider_enabled, the preprod quota checks, investigation action kinds'cannot_apply_reasons,parse_user_valueandstore_issue_last_defaultsnow take aRequestPrincipal. They only forward the caller tofeatures.has(), ignore it, or already checkhas_user(), so this is type-only.Without it, #129402's mypy check would flag 4 more files.