Skip to content

ref(typing): Let serialize() take a service account #129412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gricha merged 1 commit into from
Nov 2, 2026
+5 −2
Merged

ref(typing): Let serialize() take a service account #129412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sentry/api/serializers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,17 @@

import logging
from collections.abc import Callable, Mapping, MutableMapping, Sequence
from typing import Any, Generic, TypeVar, overload
from typing import TYPE_CHECKING, Any, Generic, TypeAlias, TypeVar, overload

from django.contrib.auth.models import AnonymousUser
from sentry_sdk import traces

from sentry.users.models.user import User
from sentry.users.services.user.model import RpcUser

if TYPE_CHECKING:
from sentry.auth.principal import RequestPrincipal

logger = logging.getLogger(__name__)

K = TypeVar("K")
Expand All @@ -21,7 +24,7 @@
# is migrated.
T = TypeVar("T", default=Any)

_User = User | RpcUser | AnonymousUser | None
_User: TypeAlias = "RequestPrincipal | None"

registry: MutableMapping[Any, Any] = {}

Expand Down
Loading