Repository navigation
Improve source popup context and reading controls - #159
Open
ishan-jawale wants to merge 7 commits into
Open
ishan-jawale wants to merge 7 commits into
ishan-jawale wants to merge 7 commits into
Conversation
Keep the original question visible in PDF and Markdown readers, with section metadata, passage navigation, and optional retention when answers arrive. Preserve request ownership across reopened readers and maintain PDF keyboard focus through answer and follow-up completion. Add unit and browser regression coverage for the reader lifecycle.
Preserve reader question context and retention controls alongside the shared sidebar and query plans. Update source-preview fixtures and browser checks for the current search/document bridge and Chat return action.
Updated instructions for using the source reader and automated checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the source popup easier to read while an answer is being generated. Students can see the original question, keep a passage open when the answer arrives, and return to the cited passage or PDF page without losing their place.
Key changes
Main implementation:
App.tsx,MarkdownSourceViewer.tsx,SourceViewerHeader.tsx,answer-source-preview.ts,hooks/useAnswerSourcePreview.ts, andsource-viewer.css.Testing
npm run buildpassed, including Node and renderer TypeScript checks and all application bundles.npm run test:unit:ts: 370 passed.npm run test:unit:python: 115 passed.npm run test:integration: 16/16 conversation pipeline contracts and Python worker/PDF integration passed.git diff --check upstream/main...HEADpassed.Notes
c7fa02fand resolved conflicts in the main screen and test documentation while preserving the shared sidebar and query-plan behavior.Screenshot
Source reader showing the original question and highlighted BuzzDB passage.