Repository navigation
Conversation
mgorny
requested changes
Jul 22, 2026
mgorny
reviewed
Jul 23, 2026
mgorny
reviewed
Jul 23, 2026
clan
force-pushed
the
verify
branch
2 times, most recently
from
July 24, 2026 10:39
0427461 to
3d70f11
Compare
mgorny
reviewed
Jul 25, 2026
Refactor list_keys() to return structured key information instead of mapping fingerprints to UID lists. Introduce dedicated dataclasses for primary keys, subkeys and key listings. Besides UIDs, the returned data now includes each key's fingerprint, key ID, creation time and expiration time parsed from GnuPG's --with-colons output, while explicitly preserving the primary/subkey relationship. Centralizing key metadata parsing in list_keys() provides a single representation of OpenPGP keys and prepares subsequent changes that require access to additional key metadata during signature verification. Signed-off-by: Z. Liu <zhixu.liu@gmail.com>
clan
force-pushed
the
verify
branch
2 times, most recently
from
July 25, 2026 15:55
ca07015 to
80f999a
Compare
Use the expiration time from imported key metadata instead of relying on KEYEXPIRED. KEYEXPIRED status messages are not associated with a specific fingerprint, making it unreliable when multiple expired keys are involved. The imported key metadata already contains the expiration time associated with each fingerprint, so use it directly. Closes: https://bugs.gentoo.org/979433 Signed-off-by: Z. Liu <zhixu.liu@gmail.com>
gentoo-bot
pushed a commit
that referenced
this pull request
Jul 25, 2026
Refactor list_keys() to return structured key information instead of mapping fingerprints to UID lists. Introduce dedicated dataclasses for primary keys, subkeys and key listings. Besides UIDs, the returned data now includes each key's fingerprint, key ID, creation time and expiration time parsed from GnuPG's --with-colons output, while explicitly preserving the primary/subkey relationship. Centralizing key metadata parsing in list_keys() provides a single representation of OpenPGP keys and prepares subsequent changes that require access to additional key metadata during signature verification. Signed-off-by: Z. Liu <zhixu.liu@gmail.com> Part-of: #43 Signed-off-by: Michał Górny <mgorny@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the key expiration time recorded when importing keys instead of relying on the KEYEXPIRED status message.
KEYEXPIRED does not identify which key it refers to, making it unreliable when multiple expired keys are involved. The imported key metadata already contains the expiration time associated with each fingerprint, so use it directly.
Closes: https://bugs.gentoo.org/979433