Repository navigation
Review of QG vignette - #353
Merged
Merged
Conversation
- Drop the claim that breeding values depend on associations between loci, which contradicts the independent-locus reference used for the effects. - Credit Fisher with the multilocus least-squares split into additive effects and dominance deviations, and Cockerham and Kempthorne with the epistatic extension. - Remove the "different route to agreement" sentence for complete inbreeding, which duplicates the two-genotype case in the table. - Describe what the Hardy-Weinberg example actually shows. - Say that the Alvarez-Castro and Crujeiras decomposition is derived in full for two loci. - Fix typos, punctuation and line wrapping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
@gregorgorjanc, I'll merge the pull request and keep working on my review of vignettes. I'm working through them in the order I'd recommend someone reading them and I haven't gotten to this one yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gaynorr would this revision of the QG vignette work? I have parsed some of the parts to try to weave in the last thoughts you discussed and I tried to simplify some of the recent additions.
@darizasu and @david20011999 could you also review and provide comments at some point?