Repository navigation
[Android] Preserve OAuth callbacks across Activity lifecycle changes - #503
Conversation
…cle changes (Complete authentication before Activity recreation)
…cle changes (Dispatch OAuth on a live Activity on the main thread)
|
||||||||||||||||
|
||||||||||||||||
…cle changes (Clarify authentication lifecycle test fixtures)
wmathurin
left a comment
There was a problem hiding this comment.
Approving. The callback is delivered before recreate(), OAuth dispatch runs on the main thread against a live Activity, and our three comments are addressed (test factory with labeled ClientInfo args, reflection coupling documented on both fields, overlapping-authenticate loss tracked as a follow-up).
Please confirm android-pr / test-android and the iOS jobs finish green on 951f002 before merging, and make sure #501 picks up dev141 after this lands so the overlapping commits drop out of its diff.
|
@wmathurin Following up on the green-CI condition: the current run passed 41/42 Android tests, including all seven OAuth lifecycle regressions. The failing test is Local Android controls using the same CI account/session, record type and API 36 emulator returned the same HTTP 500 ( iOS 18/26 each passed 35/36 tests and timed out in the same layout test. This PR changes no iOS/shared REST/test inputs; the exact iOS REST error was not archived. We’ve accepted the demonstrated server failure as baseline and deferred follow-up. Would you accept these documented baseline failures in place of the green-CI condition for this PR? After it lands, #501 will integrate updated This response was generated by an AI agent on behalf of @JohnsonEricAtSalesforce. |
1a90037
into
forcedotcom:dev141
Prevent pending React Native authentication callbacks from being lost when Android recreates the Activity after login. Complete the callback before recreation, and dispatch OAuth operations on the main thread using an Activity that is not finishing or destroyed. The existing bounded missing-Activity error remains unchanged.
Extracts the independent fixes from RN501. React Native stays at 0.86.0; dependency and toolchain declarations are unchanged.
Validation:
5cfedf4, AGP 9.1.1 and Gradle 9.4.1. The stock test-project setup and a live sign-in matrix were not rerun for this branch. Hosted CI is pending publication.After this lands, RN501 can integrate
dev141, removing the overlapping OAuth changes from its upgrade diff without rewriting published history.This response was generated by an AI agent on behalf of @JohnsonEricAtSalesforce.