Skip to content

[ReactNative][Android] Fix first launch without client manager - #490

Merged
brandonpage merged 1 commit into
forcedotcom:devfrom
brandonpage:codex/fix-rn-first-launch-client-manager
Aug 25, 2026
Merged

brandonpage merged 1 commit into
forcedotcom:devfrom
brandonpage:codex/fix-rn-first-launch-client-manager

Conversation

@brandonpage

Copy link
Copy Markdown
Contributor

Summary

  • rebuild the ClientManager when SalesforceReactActivity resumes
  • preserve the normal unauthenticated login path when no manager exists on first launch
  • log out and return when an existing manager cannot restore a RestClient
  • remove handling for the legacy AccountInfoNotFoundException, since peekRestClient now reports failure with null

Testing

  • generated MobileSyncExplorerReactNative release app assembled successfully
  • com.salesforce.mobilesdk.mobilesdkuitest.login.LoginTest passed on Pixel 10 API 36.1: 1 test, 0 failures

@brandonpage
brandonpage requested a review from wmathurin August 25, 2026 19:50
@github-actions

Copy link
Copy Markdown
TestsPassedSkippedFailed ❌️
iOS ^26 Test Results35 ran35 ❌
TestResult
iOS ^26 Test Results
ReactHarnessTests.testAsyncPassing()❌ failure
ReactHarnessTests.testPassing()❌ failure
ReactMobileSyncTests.testCleanResyncGhosts()❌ failure
ReactMobileSyncTests.testGetSyncStatusDeleteSync()❌ failure
ReactMobileSyncTests.testReSync()❌ failure
ReactMobileSyncTests.testSyncDown()❌ failure
ReactMobileSyncTests.testSyncUp()❌ failure
ReactNetTests.testCollectionCreateDeleteRetrieve()❌ failure
ReactNetTests.testCollectionCreateRetrieve()❌ failure
ReactNetTests.testCollectionUpsertUpdateRetrieve()❌ failure
ReactNetTests.testCreateDelRetrieve()❌ failure
ReactNetTests.testCreateRetrieve()❌ failure
ReactNetTests.testDescribe()❌ failure
ReactNetTests.testDescribeGlobal()❌ failure
ReactNetTests.testDescribeLayout()❌ failure
ReactNetTests.testGetApiVersion()❌ failure
ReactNetTests.testMetaData()❌ failure
ReactNetTests.testPublicApiCall()❌ failure
ReactNetTests.testQuery()❌ failure
ReactNetTests.testResources()❌ failure
ReactNetTests.testSearch()❌ failure
ReactNetTests.testUpsertUpdateRetrieve()❌ failure
ReactNetTests.testVersions()❌ failure
ReactOAuthTests.testGetAuthCredentials()❌ failure
ReactSmartStoreTests.testClearSoup()❌ failure
ReactSmartStoreTests.testGetDatabaseSize()❌ failure
ReactSmartStoreTests.testGetRemoveGlobalStores()❌ failure
ReactSmartStoreTests.testGetRemoveStores()❌ failure
ReactSmartStoreTests.testGetSoupIndexSpecs()❌ failure
ReactSmartStoreTests.testMoveCursor()❌ failure
ReactSmartStoreTests.testQuerySoup()❌ failure
ReactSmartStoreTests.testRegisterExistsRemoveExists()❌ failure
ReactSmartStoreTests.testRemoveFromSoup()❌ failure
ReactSmartStoreTests.testSmartQuerySoup()❌ failure
ReactSmartStoreTests.testUpsertRetrieve()❌ failure

@brandonpage

Copy link
Copy Markdown
Contributor Author

Android CI update: this headless failure predates this PR and is also present on #489. Firebase Test Lab logcat traced it to a NetworkOnMainThreadException in Android SDK TestAuthenticationActivity before HeadlessTestApp mounts.

The upstream fix is forcedotcom/SalesforceMobileSDK-Android#3006. With that patch applied locally, the React Native headless run completed all 35 JavaScript tests successfully, and ReactHarnessTest.testAsyncPassing passed.

@brandonpage
brandonpage merged commit 8268343 into forcedotcom:dev Aug 25, 2026
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants