Repository navigation
docs(schema): clarify ValueSpecification.inputs key order and fix FQName/Reference examples in IR v4 - #1103
Open
whawk46 wants to merge 1 commit into
Conversation
…ame/Reference examples in IR v4 schema
- States explicitly that the key order of ValueSpecification.inputs in canonical object form is the parameter order.
- Fixes the FQName legacy array example at L138 to use the 3-element [packageName, moduleName, name] form ([[["morphir"], ["s", "d", "k"]], [["list"]], ["map"]]) matching maxItems: 3.
- Aligns ReferenceType canonical (with args) description at L835 with L735 on the object form ({"Reference": {"fqname": "morphir/SDK:list#list", "args": ["a"]}}).
Closes finos#1102
Signed-off-by: Walter Hawkins <wdhawkins46@gmail.com>
✅ Deploy Preview for angry-raman-7c44f6 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the three IR v4 JSON Schema items in
website/static/schemas/morphir-ir-v4.yamlreported in #1102:ValueSpecification.inputsparameter order (L2071–L2085): Explicitly states that in the canonical object form ({ "x": type, "y": type }), the key order ofinputsis the parameter order.FQNamelegacy array example (L138): Fixes the second example from the 4-element array[["morphir"], ["s", "d", "k"], ["list"], ["map"]]to the 3-element[packageName, moduleName, name]tuple[[["morphir"], ["s", "d", "k"]], [["list"]], ["map"]]matchingmaxItems: 3anddocs/spec/ir/schemas/v4/index.md.Referencewith arguments (L835): Aligns theReferenceTypecanonical (with args) description withL735on the object form ({"Reference": {"fqname": "morphir/SDK:list#list", "args": ["a"]}}).Closes #1102
Institutional Integration Context
Encountered and validated while integrating Morphir IR v4 schema tooling with Ashlar Blue (
ashlar.blue) — Non-Custodial Digital Financial Market Infrastructure (D-FMI), Institutional Clearinghouse, and Hardware-Attested Enclave Settlement Engine.