Repository navigation
Conversation
Member
|
Thanks for this PR! I'm closing it for now, but feel free to reopen in accordance with our Contributing Guide (you need to open the PR and fill in the template yourself). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2767.
What changed
The fix is complete. Here's what was done:
Changes Summary
falcon/response.py_prepare_header(name, value)helper function that validates ASCII names and Latin-1 encodable valuesset_header,append_header, andset_headersto use the new helpertests/test_headers.pyTestHeaderASCIIValidationclass with 17 new teststest_unicode_headers_contain_non_asciito reflect new behaviortests/test_error_reporter.pytest_report_fatal_error_rendering_asgi_headersto expect 500 response instead of raised ValueErrorTest Results
test_headers.pypassHow it was verified
tests/test_error_reporter.py,tests/test_headers.pyThis was worked on in conjunction with AI tools.