Repository navigation
fix(rpcbootstrap): schedule Hoodi Amsterdam in the EL fork id - #904
Merged
Merged
Conversation
go-ethereum v1.17.6 (and current releases/master) ship a Hoodi chain config without amsterdamTime, so the bootstrap Status advertised 0x23aa1351/0 and the fork filter would reject upgraded peers once Hoodi forks at 1793036568 (eth-clients/hoodi#31). Use a copy of params.HoodiChainConfig with AmsterdamTime set when the bundled config lacks it, so this becomes a no-op once go-ethereum ships the timestamp. Hoodi now advertises 0x23aa1351/1793036568 before the fork and 0x3d068b59/0 after it; mainnet and Sepolia are unchanged.
samcm
force-pushed
the
fix/hoodi-amsterdam-forkid
branch
from
October 19, 2026 00:37
565ba8f to
0cf70b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoodi forks to Amsterdam at 1793036568 (eth-clients/hoodi#31), but go-ethereum's bundled Hoodi config (v1.17.6 and every later release) has no amsterdamTime. The rpcbootstrap Status that EL mimicry and discovery send therefore advertised fork id 0x23aa1351/0, which upgraded peers will reject after the fork.
bootstrapNetworknow uses a copy ofparams.HoodiChainConfigwithAmsterdamTimeset when the bundled config lacks it, and go-ethereum's own value once it has one. Hoodi now advertises 0x23aa1351/1793036568 before the fork and 0x3d068b59/0 after; a new test pins these alongside the unchanged mainnet and Sepolia ids.