Repository navigation
Keep enodes.yaml to enode records - #127
Merged
Merged
Conversation
Contributor
Author
kdeme
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the NodeOps bootnode PR, addressing @kdeme's review comment:
metadata/enodes.yamlis the discv4 enode list, so it should not carry ENRs.What changes
metadata/enodes.yaml,metadata/besu.jsonandmetadata/chainspec.json. The three lists stay identical, as the consistency check requires.metadata/bootstrap_nodes.yamlis untouched.Where the EL ENRs live now
Each EL client repository carries them directly (go-ethereum, erigon, reth, Besu, ethrex, Nethermind), so nothing downstream loses a record. If maintainers would rather have the EL discv5 records in this repository as well,
bootstrap_nodes.yamlor a separate file both work; happy to follow up either way.