Skip to content

fix(ses): Permit bogus caller and arguments on TextEncoder and TextDecoder that shipped in some versions of chrome prior to 127 #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
naugtur wants to merge 1 commit into from
Closed

fix(ses): Permit bogus caller and arguments on TextEncoder and TextDecoder that shipped in some versions of chrome prior to 127 #3371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/ses/src/permits.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,10 @@ const accessor = {
set: fn,
};

const nullDesc = {
value: null,
}

// eslint-disable-next-line func-names
const strict = function () {
'use strict';
Expand Down Expand Up @@ -2194,6 +2198,8 @@ export const permitted = {
// Properties of the TextEncoder Constructor
'[[Proto]]': '%FunctionPrototype%',
prototype: '%TextEncoderPrototype%',
arguments: nullDesc,
caller: nullDesc,
},

'%TextEncoderPrototype%': {
Expand All @@ -2211,6 +2217,8 @@ export const permitted = {
// Properties of the TextDecoder Constructor
'[[Proto]]': '%FunctionPrototype%',
prototype: '%TextDecoderPrototype%',
arguments: nullDesc,
caller: nullDesc,
},

'%TextDecoderPrototype%': {
Expand Down
21 changes: 21 additions & 0 deletions packages/ses/test/permits-chrome-126.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// @ts-nocheck
import test from 'ava';
import 'ses';

test('TextEncoder arguments and caller properties as seen in chrome 126 are permitted', t => {
// Reproduce the broken behavior in Chrome 126
const descr = {
value: null,
writable: false,
enumerable: false,
configurable: false,
};
Object.defineProperty(globalThis.TextEncoder, 'caller', descr);
Object.defineProperty(globalThis.TextEncoder, 'arguments', descr);
Object.defineProperty(globalThis.TextDecoder, 'caller', descr);
Object.defineProperty(globalThis.TextDecoder, 'arguments', descr);

t.notThrows(() => {
lockdown();
});
});
Loading