Repository navigation
Keep visiting every operation when a callback removes or inserts operations (#2269, 3.x) - #551
Merged
Merged
Conversation
This was referenced Nov 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #550 to 3.x, with the same tests adapted to mocha and expect.js.
Since 3.8.0, queries that mix
withGraphJoined()andwithGraphFetched()and select all columns of the root table return no fetched relations, without an error (Vincit/objection.js#2269). AnonBuild()hook that removes operations, e.g. withclearSelect(), also made the query skip building the next operation, e.g. thewhereoffindById(). Adding, removing and replacing root operations now creates a new array, andforEachOperation()starts over on it, skipping the operations it already visited.