Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integer sample weights currently make weighted quantiles fail during CDF normalization:
Accumulate the CDF with a dtype promoted to at least float64. This accepts integer lists/arrays and avoids integer accumulation overflow while preserving extended floating precision. The existing quantile convention is unchanged.
Regression tests cover integer lists, signed arrays and unsigned arrays. The complete suite passes on Python 3.12 and 3.14, with the existing skip, and all pre-commit hooks pass. On archived eight-schools posterior draws, integer-weight plots, titles and percentile ranges match the corresponding floating-weight results, including rendered images.