Skip to content

fix(tls): distrust compromised eMudhra certificate authorities #37046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartlomieju merged 3 commits into from
Oct 20, 2026
+58 −34
Merged

fix(tls): distrust compromised eMudhra certificate authorities #37046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ed9bea
fix(tls): distrust compromised eMudhra certificate authorities
bartlomieju Oct 20, 2026
9787a28
fix(crypto): use stable AWS-LC ML-DSA APIs
bartlomieju Oct 20, 2026
5967dcf
chore: bump deno_graph to 0.111.1
bartlomieju Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 40 additions & 18 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ deno_ast = { version = "=0.53.3", features = ["transpiling"] }
deno_core_icudata = "0.77.0"
deno_doc = "=0.207.0"
deno_error = "=0.7.1"
deno_graph = { version = "=0.111.0", default-features = false }
deno_graph = { version = "=0.111.1", default-features = false }
deno_lint = "=0.84.1"
deno_media_type = { version = "=0.4.0", features = ["module_specifier"] }
deno_native_certs = "0.3.0"
Expand Down Expand Up @@ -191,7 +191,7 @@ async-compression = "0.4"
async-once-cell = "0.5.4"
async-stream = "0.3"
async-trait = "0.1.73"
aws-lc-rs = { version = "1.16.3" }
aws-lc-rs = { version = "1.18.2" }
aws-lc-sys = { version = "0.40.0", features = ["prebuilt-nasm"] }
backhand = { version = "0.25.1", default-features = false, features = ["zstd"] }
base32 = "=0.5.1"
Expand Down Expand Up @@ -299,7 +299,7 @@ rusqlite = { version = "0.40.0", features = ["unlock_notify", "bundled", "sessio
rustls = { version = "=0.23.40", default-features = false, features = ["logging", "std", "tls12", "aws_lc_rs"] }
rustls-pemfile = "2"
rustls-tokio-stream = "=0.8.0"
rustls-webpki = "0.103"
rustls-webpki = "0.103.16"
rustyline = { version = "=17.0.0", features = ["custom-bindings"] }
rustyline-derive = "=0.11.1"
same-file = "1.0.6"
Expand Down Expand Up @@ -343,8 +343,8 @@ urlpattern = "=0.4.2"
uuid = { version = "1.3.0", features = ["v4"] }
walkdir = "=2.5.0"
web-transport-proto = "0.2.7"
webpki-root-certs = "0.26.5"
webpki-roots = "0.26"
webpki-root-certs = "1.0.10"
webpki-roots = "1.0.10"
which = { version = "8.0.0", default-features = false }
yoke = { version = "0.7.4", features = ["derive"] }
zeromq = "0.6"
Expand Down
24 changes: 13 additions & 11 deletions ext/crypto/mldsa.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
// Copyright 2018-2026 the Deno authors. MIT license.

use aws_lc_rs::signature::KeyPair;
use aws_lc_rs::signature::ML_DSA_44;
use aws_lc_rs::signature::ML_DSA_44_SIGNING;
use aws_lc_rs::signature::ML_DSA_65;
use aws_lc_rs::signature::ML_DSA_65_SIGNING;
use aws_lc_rs::signature::ML_DSA_87;
use aws_lc_rs::signature::ML_DSA_87_SIGNING;
use aws_lc_rs::signature::PqdsaKeyPair;
use aws_lc_rs::signature::PqdsaSigningAlgorithm;
use aws_lc_rs::signature::PqdsaVerificationAlgorithm;
use aws_lc_rs::signature::UnparsedPublicKey;
use aws_lc_rs::unstable::signature::ML_DSA_44;
use aws_lc_rs::unstable::signature::ML_DSA_44_SIGNING;
use aws_lc_rs::unstable::signature::ML_DSA_65;
use aws_lc_rs::unstable::signature::ML_DSA_65_SIGNING;
use aws_lc_rs::unstable::signature::ML_DSA_87;
use aws_lc_rs::unstable::signature::ML_DSA_87_SIGNING;
use aws_lc_rs::unstable::signature::PqdsaKeyPair;
use aws_lc_rs::unstable::signature::PqdsaSigningAlgorithm;
use aws_lc_rs::unstable::signature::PqdsaVerificationAlgorithm;
use spki::der::Encode;
use spki::der::asn1::BitString;

Expand Down Expand Up @@ -324,7 +324,9 @@ pub(crate) fn mldsa_export_pkcs8(
let p = params(variant)?;
let key_pair = PqdsaKeyPair::from_seed(p.signing, seed)
.map_err(|_| MlDsaError::InvalidKeyData)?;
let pkcs8 = key_pair.to_pkcs8().map_err(|_| MlDsaError::FailedExport)?;
let pkcs8 = key_pair
.to_pkcs8v1()
.map_err(|_| MlDsaError::FailedExport)?;
Ok(pkcs8.as_ref().to_vec())
}

Expand Down Expand Up @@ -395,7 +397,7 @@ trait AsRawBytesVec {
fn as_raw_bytes_vec(&self) -> Result<Vec<u8>, ()>;
}

impl AsRawBytesVec for aws_lc_rs::unstable::signature::PqdsaPrivateKey<'_> {
impl AsRawBytesVec for aws_lc_rs::signature::PqdsaPrivateKey<'_> {
fn as_raw_bytes_vec(&self) -> Result<Vec<u8>, ()> {
use aws_lc_rs::encoding::AsRawBytes;
let raw = self.as_raw_bytes().map_err(|_| ())?;
Expand Down
Loading