Repository navigation
Inno Setup script - Improve script - #910
Conversation
Added Italian language support and reintroduced Vietnamese.
Updated license file path and desktop icon name.
|
Could you please check and merge? |
| Italian.NameAndVersion={#AppShortName} {#AppVersion} | ||
| Italian.LaunchProgram=Esegui {#AppShortName} | ||
| Italian.AdditionalIcons=Collegamenti: | ||
| Italian.CreateDesktopIcon=Crea collegamento programma sul &desktop |
There was a problem hiding this comment.
Do the base language files need updating? I'd rather avoid changes to Inno strings that aren't NAPS2-specific
There was a problem hiding this comment.
The changes are neecssary because the originla strings (Italian.isl) are not right for the action.
You dodn't add icon on desktop.
You creatre a program shortcut on desktop and this shortcut has an icon
TTo avoid to change the base fiel (Italia.isl) that yoiu can overwrite if update the Inno Setup version the best solution is to add in CustomMessages section.
| DefaultDirName={commonpf}\{#AppShortName} | ||
| DefaultGroupName={#AppShortName} | ||
| LicenseFile=..\..\LICENSE | ||
| LicenseFile=..\..\LICENSE.rtf |
There was a problem hiding this comment.
There's already a license.rtf file in the NAPS2.Setup folder, we should use that instead of adding a new one
There was a problem hiding this comment.
@cyanfiush
The file "LICENSE" seems that is not RTF file.
It's a text file that has a forced 80 chars line that create the issue that i show with screenshot.
The file that I posted it's a real RTF file without this issue.
There was a problem hiding this comment.
Yes, there is already a rtf too, please check the repo
There was a problem hiding this comment.
@cyanfish
I didn't see that in NAPS2.Setup is present licens.rtf.
I just see that you point in original script to
https://github.com/cyanfish/naps2/blob/master/LICENSE
that is a text file not formatted.
If you like you can change the license refrence to
https://github.com/cyanfish/naps2/blob/master/NAPS2.Setup/license.rtf
I changes the commit to point to license.rtf
| [Icons] | ||
| Name: "{group}\NAPS2"; Filename: "{app}\{#ExeName}" | ||
| Name: "{commondesktop}\NAPS2"; Filename: "{app}\{#ExeName}"; Tasks: desktopicon | ||
| Name: "{commondesktop}\NAPS2"; Filename: "{app}\{#AppShortName}"; Tasks: desktopicon |
There was a problem hiding this comment.
Why this change? Icons come from the exe, right?
There was a problem hiding this comment.
@cyanfish
Because as it now uis not right (see screenshot)..
You run not the .exe file but the program.
Then like now "Run NAPS2.exe" is not right.
It's right "Run NAPS2".
@cyanfish
Improve Inno Setup scritps.
Fix an issue about license text
Use RTF license file without forced new line
Fix and issue about program name without ".exe".
Add some strings for Italian language to fix some issues about base Italian language (Italian.isl).