Repository navigation
fix(nextcloud-whitelist): allow WebDAV PUT requests on /remote.php/dav/ (#1915) - #1994
Open
hrithiksaini99 wants to merge 1 commit into
Open
hrithiksaini99 wants to merge 1 commit into
hrithiksaini99 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1915.
Description
In
parsers/s02-enrich/crowdsecurity/nextcloud-whitelist.yaml, the expression for WebDAV uploads:expressly comments
#Uploading new files via WebDAV always produces a 404, but omits HTTPPUTfrom the verbs list.When WebDAV sync clients (e.g. Nextcloud desktop sync or mobile client sync) upload files, directory tree copy/sync emits
PUTrequests that can legitimately return404before resource creation or on chunked uploads. WithoutPUTwhitelisted, these 404s overflowcrowdsecurity/http-probingand cause false-positive IP bans for legitimate users.This PR adds
'PUT'to the verb list innextcloud-whitelist.yaml.