Repository navigation
chore: 2026 reboot - #10
Merged
Merged
Conversation
srl295
commented
Oct 1, 2026
srl295
commented
Member
- add AGENTS
- stability and packaging
Resolve the planned fixes tracked in AGENTS.md. Correctness: - plugin-taskw: guard the githubbody/annotations truncation with Array.isArray(j) && j.length > 0 && j[0]; it previously dereferenced j[0] unguarded, so a non-array or empty export crashed. - plugin-taskw: accumulate stderr into `err` instead of only printing it, so the actual failure reason reaches the rejection message rather than a bare "non zero exit". - cli: add requireBaseDir(), used by getList()/getDir(). baseDir was undefined when `dir` was never configured, which failed opaquely in fs.opendir()/path.join(). - cli: flatten the getList() project filter into guard clauses. The nested if/else made the "no taskwarrior field + project filter" case look like dead code when it is the documented exclusion rule. - cli: store `date` as an explicit ISO string instead of relying on JSON.stringify's Date coercion, and mark MourtBlob's taskwarrior, shortDate and localDate optional to match what is actually on disk. - cli: drop the unused readFile import. - plugin-taskw: remove the no-op fetchTask -> fetchData wrapper. Packaging: - tsconfig: add rootDir "."/outDir "dist", declaration true, and drop the redundant "module": "commonjs" (already set by @tsconfig/node16). - bin/mourt: require ../dist/lib/cli and explain the compiled-vs-source split. - lib/config.ts: require ../../package.json, since the compiled file now lives at dist/lib/ rather than lib/. - package.json: add exports/types/files; point main at dist/main.js. files ships dist/**/*.js and dist/**/*.d.ts, excluding .ts sources and .map files. - .npmignore: delete, now superseded by the files field. Verified via CLI smoke tests, an npm pack install test, and a full parse of the existing 1520-entry dataset. No test suite exists yet; npm test still exits 1 by design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.