Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Motivated by #6145.
We have several CLI commands that 1) ask the user whether they want to log in with spacetimedb.com, and 2) automatically use a server-issued login if the user passed
--yes.This PR updates the behavior so that 1) we print a warning and ask the user if they're super-sure, and 2) reject
--yesif the user is not logged in.This is to minimize the poor-UX situations where users end up with a "split identity" between their local DB and maincloud, where they end up trying to juggle multiple identities. The intended behavior is (and has been for a while) that users use the spacetimedb.com login on all servers.
Reverts #6116.
API and ABI breaking changes
This changes the behavior of
spacetime --yesfor any commands that used to ask whether you wanted a server-issued-login.Rollback safety impact
n/a
Expected complexity level and risk
1
Testing
Simplified the Core login smoketests to check for
WARNINGinstead of matching prompt wording, and for onlyYou are not logged inon stderr when rejecting--yes.