Repository navigation
feat: modernize RadioButton for MD3 #5007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
burczu
wants to merge
29
commits into
callstack:main
Choose a base branch
from
burczu:feat/radio-button-md3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+714
−1,210
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
6221077
refactor(radio-button): merge platform variants into one MD3 component
burczu a155b74
feat(radio-button): add MD3 tokens, error state, single animation path
burczu 015baf4
perf(radio-button): memoize group context, switch to useContext
burczu 9649647
fix(radio-button): single a11y node per item, error + parity cleanup
burczu 9e4a668
docs(radio-button): update example + drop platform variant docs
burczu d9f3973
fix(radio-button): apply disabled opacity, animate group selection
burczu ee00e84
docs(radio-button): dim disabled labels, add unchecked error examples
burczu c0e1c18
refactor(radio-button): migrate dot animation to reanimated
burczu e486e99
fix(radio-button): fix post-rebase CI failures
burczu 2b4eebb
fix(radio-button): fix prettier formatting in utils.ts
burczu 1d1ea02
docs(radio-button): drop deleted pages from _meta.json
burczu 3c226a1
docs(radio-button): remove deleted components from docs config
burczu ea2a6e9
fix(radio-button): address PR review comments
burczu a1a3e75
fix: prevent nested item control from receiving focus
MikitasK feb9a54
fix: use 40dp MD3 state layer
MikitasK 5554631
Merge branch 'main' of https://github.com/callstack/react-native-pape…
MikitasK 12644a8
refactor: address review feedback
MikitasK e0366bc
docs: add v6 migration guidance
MikitasK 4008f1a
Merge branch 'main' of https://github.com/callstack/react-native-pape…
MikitasK 12e10e1
fix: keep 48dp touch target for Checkbox and RadioButton
MikitasK 1fc4903
test: cover getMinTouchTargetHitSlop
MikitasK 98786fd
Merge upstream main into feat/radio-button-md3
MikitasK af9cb8c
docs: document web hitSlop limitation
MikitasK 4bb43cd
Merge upstream main into feat/radio-button-md3
MikitasK ec36997
fix: use a 48dp layout touch target
MikitasK a427945
fix: animate radio dot with css transitions
MikitasK 3578b0d
test: cover radio group onValueChange through public api
MikitasK cbb7784
docs: correct radio size notes in migration guide
MikitasK f9aff80
docs: keep v5 radio screenshots out of 6.x pages
MikitasK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RadioButton.Itemstill usesradio-item.ios.pngandRadioButton.Groupstill usesradio-button-group-ios.gif. Both show the iOS checkmark that this PR removes, so the 6.x docs pages show a control that no longer exists. Replace them with screenshots of the new control, or remove the iOS entries. (via Claude, verify if it makes sense)