Repository navigation
Keep a leading U+FEFF when decoding binary strings - #1572
Merged
Merged
Conversation
getTextEncoding() built its UTF-8 decoders without ignoreBOM. The WHATWG decoder strips a leading U+FEFF, so fromBinary dropped that code point from string fields. Both decoders now set ignoreBOM, and the strict decoder still uses fatal. Adds a decodeUtf8 case and a StringValue round trip.
|
|
timostamm
approved these changes
Nov 2, 2026
timostamm
left a comment
timostamm
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. I've pushed up corresponding docs changes and additional tests, and updated the PR description to call out the behavioral change. LGTM!
This comment was marked as low quality.
This comment was marked as low quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1567: A leading U+FEFF in a protobuf string is part of the value, not a byte-order mark. protobuf-es created its
TextDecoderwithoutignoreBOM, sofromBinarysilently removed one leading U+FEFF from every string it reads.This PR passes
ignoreBOM: trueto both the lenient and the strict decoder ingetTextEncoding(). As a result, strings decoded by protobuf-es now keep a leading U+FEFF.If you depended on the old behavior, strip the character yourself after decoding, for example
value.replace(/^\uFEFF/, "").