Repository navigation
Conversation
Substrate still links against console 0.15.x while the workspace uses console 0.16.x. Each version keeps its own global color state, so disabling colors only in 0.16 left Substrate's console-styled log messages colored. tracing-subscriber then escaped those embedded ANSI codes into literal `\x1b[` text. Depend on console 0.15.11 in subspace-process and disable colors in both versions during init_logger. Extend the regression test to cover the 0.15 path used by Substrate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables console colors in both console 0.15 and 0.16 during init_logger, since Substrate links against 0.15 while the workspace uses 0.16. Each version keeps its own global color state.