Repository navigation
Conversation
Add an optional benchmarks_url to board enrichments, passed through the normaliser to BoardDetail. When set, the board page's links card shows a "<board> benchmark results" row (all 17 locales). Seeded with sbc.compare links for 64 boards that have verified public results. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bretmlw
marked this pull request as draft
October 15, 2026 10:49
Member
Author
|
Closing after #47 was pointed out, will revisit in the future if 3rd party results are ever of interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I previously discussed this with Igor, and thought that I'd pull my finger out and work on it myself so it was easier for you guys. Ultimately, the idea is to include sbccompare benchmark result links on the board pages so that users can quickly go and check benchmark results for a board they're looking to flash. 64 boards match at this stage, though I'll have the full changes/checks summarised below. A partner API is available should we want to do anything further with data in the future but that's a bigger change and maybe it's best to stick to something simple like this for now.
What this changes
Adds an optional
benchmarks_urlfield to board enrichment data. When it is set, the board page shows one extra row in the links card (under "Build documentation"): " benchmark results", with aChartColumnicon, linking to independent benchmark results on sbc.compare. Boards without the field look exactly as they do today.packages/schemas:benchmarks_urladded toBoardEnrichmentSchema(optional URL) andBoardDetailSchema(nullable, defaults tonull)apps/api: the normaliser passes it through fromenrichments.json, the same way assocandsummaryapps/www: the row is rendered only when the field is present; the label is a newboard.benchmarkskey in all 17 locales, with{board}interpolatedapps/api/data/enrichments.json: links for 64 boards. The three existing QDL entries are untouched apart from gaining the field.How the boards were mapped
rpi4bcovers every 64-bit Pi, so it links to the Raspberry Pi overview page rather than a single model..eos) boards have no page on armbian.com and are excluded.Testing
./manage.sh quality all,lintandformatall pass.website-quality.ymlpasses, and every locale's label contains{board}.en,de,ja)radxa-dragon-q6a,radxa-dragon-q8b,arduino-uno-q) still load their QDL data, and the QDL asset cache skips the entries that have noqdlblockBoardSummaryis unchanged; the field is only on the detail response, so the Imager and other API consumers are unaffected.Maintenance
I keep the mapping on my side and will send small follow-up PRs that only touch
enrichments.jsonwhen boards are added, or if one ever stops being public. You shouldn't need to maintain anything.🤖 Generated with Claude Code