Skip to content

Avoid resolving a MethodHandle for every event listener invocation #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BonsUnleashed wants to merge 1 commit into
base: 1.20
Choose a base branch
from
Open

Avoid resolving a MethodHandle for every event listener invocation #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions common/src/main/java/dev/architectury/event/EventFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,32 +25,46 @@
import dev.architectury.injectables.annotations.ExpectPlatform;
import org.jetbrains.annotations.ApiStatus;

import java.lang.invoke.MethodHandle;
import java.lang.invoke.MethodHandles;
import java.lang.invoke.MethodType;
import java.lang.reflect.Method;
import java.lang.reflect.Proxy;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.concurrent.ConcurrentHashMap;
import java.util.function.Consumer;
import java.util.function.Function;

public final class EventFactory {
private static final MethodType INVOKER_TYPE = MethodType.methodType(Object.class, Object.class, Object[].class);
private static final Map<Method, MethodHandle> INVOKERS = new ConcurrentHashMap<>();

private EventFactory() {
}

public static <T> Event<T> of(Function<List<T>, T> function) {
return new EventImpl<>(function);
}

@SafeVarargs
public static <T> Event<T> createLoop(T... typeGetter) {
if (typeGetter.length != 0) throw new IllegalStateException("array must be empty!");
return createLoop((Class<T>) typeGetter.getClass().getComponentType());
}

private static <T, R> R invokeMethod(T listener, Method method, Object[] args) throws Throwable {
return (R) MethodHandles.lookup().unreflect(method)
.bindTo(listener).invokeWithArguments(args);
MethodHandle invoker = INVOKERS.get(method);
if (invoker == null) {
invoker = MethodHandles.lookup().unreflect(method)
.asSpreader(Object[].class, method.getParameterCount())
.asType(INVOKER_TYPE);
INVOKERS.putIfAbsent(method, invoker);
}
Object result = invoker.invokeExact((Object) listener, args);
return (R) result;
}

@SuppressWarnings("UnstableApiUsage")
Expand Down