Repository navigation
[MINOR][VL] Remove stale Delta nested-map MERGE known failures - #13508
Merged
rui-mo merged 1 commit intoNov 3, 2026
Merged
Conversation
Remove 14 entries fixed by the merged Spark transform_keys implementation in apache#13490. Preserve all existing comments and unrelated known failures. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the cleanup of stale Delta test failure expectations.
No open issues 🎉
What changed in this PR
Cleans up the Delta test failure baseline after the merged transform_keys fix in #13490, so the CI gate expects the affected nested-map MERGE tests to pass.
Changes:
- Removes 14 stale expected-failure entries across eight generated suites, reducing the baseline from 485 to 471.
- Preserves all comments and other entries, with no production changes or new test exclusions.
| File | Description |
|---|---|
.github/workflows/util/delta-spark-ut/known-failures.txt |
Removes expected failures for two nested-map struct-key schema-evolution scenarios. |
Review effort: Balanced
Contributor
Author
felipepessoto
added a commit
to felipepessoto/gluten
that referenced
this pull request
Oct 31, 2026
All seven DATE-to-TIMESTAMP_NTZ cases executed and passed in Delta 4.4.1 run 41243077329 with the merged Velox reader patch. Keep the unrelated fourteen nested-map entries for PR apache#13508 and preserve strict gate behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Oct 31, 2026
Contributor
Author
rui-mo
approved these changes
Nov 3, 2026
felipepessoto
added a commit
to felipepessoto/gluten
that referenced
this pull request
Nov 3, 2026
All seven DATE-to-TIMESTAMP_NTZ cases executed and passed in Delta 4.4.1 run 41243077329 with the merged Velox reader patch. Keep the unrelated fourteen nested-map entries for PR apache#13508 and preserve strict gate behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Remove 14 stale Delta nested-map MERGE entries from
known-failures.txt(485 to 471). They were fixed by #13490: Sparktransform_keyspermits null fields inside a non-null struct map key, unlike the Presto implementation.Baseline-only and independent of #13502; existing comments and unrelated entries are unchanged.
How was this patch tested?
Compared saved before and after CI reports: all 14 cases changed from indeterminate-key failures to passes, with no skips. Replaying the unchanged
compare-test-results.py --fail-on-fixed trueagainst the updated baseline passes all eight affected suites (256 tests).The full borrowed-report replay still reports the same ten unrelated native-write failures baselined only in #13502; they are untouched here. This was a replay, not a new full-suite run.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: GitHub Copilot 1.0.102-0.unstable.r40949665530.gab1eef5 (gpt-6-astra)