Repository navigation
[flink] Retry initial lake snapshot commit in enable_fluss_on_lake_table - #4919
Open
sakshichitnis27 wants to merge 1 commit into
Open
sakshichitnis27 wants to merge 1 commit into
sakshichitnis27 wants to merge 1 commit into
Conversation
The coordinator learns about a newly created table asynchronously via ZooKeeper, so committing the initial lake snapshot right after creating the Fluss table can fail with TableNotExistException. Retry the commit for a bounded time when that happens. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
sakshichitnis27
marked this pull request as ready for review
October 27, 2026 18:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4907
EnableFlussOnLakeTableProcedureITCase.testReenableExistingTableWithRegisteredSnapshotoccasionally fails withTableNotExistException: Table N not found or queued for deletion in coordinator context.enable_fluss_on_lake_tablecreates the Fluss table viacreateTableFromLakeand then immediately commits the initial lake snapshot. The table is written to ZooKeeper right away, but the coordinator only adds it to its context once the table watcher'sCreateTableEventis processed. If the commit request reaches the coordinator first, it is rejected.Brief change log
EnableFlussOnLakeTableProcedurenow retries the initial lake snapshot commit (up to 10 attempts, backoff from 100ms to 2s) when the failure is caused byTableNotExistException. Any other failure is thrown on the first attempt.Tests
EnableFlussOnLakeTableProcedureTest: added a test that the commit is retried until the coordinator knows the table, and one that other failures are not retried.CreateTableEventis put on the coordinator event queue inTableChangeWatcher(not included in this PR). With the delay,EnableFlussOnLakeTableProcedureITCase#testReenableExistingTableWithRegisteredSnapshotfailed with the same error as in the issue before this change, and passes with it. All 8 tests inEnableFlussOnLakeTableProcedureITCasealso pass with and without the delay.API and Format
No API or storage format change.
Documentation
No documentation change.