Repository navigation
Conversation
Start and close a dedicated cluster for each test so system tables and cached initialization state share a lifecycle. Assert that the consumer-offset table exists after owner resolution to detect stale-cache false positives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #4912
Prevent
ConsumerOffsetTableITCasefrom reusing cached initialization state after the previous test deletes the system table.Brief change log
sys.consumer_offsetsexists after owner resolution.Tests
Adding the existence assertion without the lifecycle fix makes one of the two integration tests fail.
With the fix, all 23 targeted tests passed on Java 11:
./mvnw -B -pl fluss-server -am test '-Dtest=ConsumerOffset*Test,ConsumerOffsetTableITCase,GroupManagerTest' -Dsurefire.failIfNoSpecifiedTests=false
Checkstyle, Spotless, and license checks passed. The full repository suite was not run.
API and Format
No changes. Production code is unchanged.
Documentation
No documentation changes.
Generative AI disclosure
Generated-by: OpenAI Codex
OpenAI Codex assisted with implementation, tests, and PR preparation.