Repository navigation
[server] Add HLL sketch aggregation merge function #3337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rahulbsw
wants to merge
8
commits into
apache:main
Choose a base branch
from
rahulbsw:hll-sketch-aggregation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+631
−0
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5d39870
[server] Add HLL sketch aggregation merge function
a8156b2
[server] List DataSketches dependencies in NOTICE
2b962f8
Merge branch 'main' into hll-sketch-aggregation
rahulbsw b6f3125
[server] Merge upstream main into HLL sketch aggregation
b6797b4
[server] Preserve existing HLL branch merge history
527a67a
[server] Preserve DataSketches Memory license terms
a6e2921
[server] Relocate DataSketches and Memory in shaded JAR
d395e62
[docs] Explain reading estimates from stored HLL sketches
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
...java/org/apache/fluss/server/kv/rowmerger/aggregate/factory/FieldHllSketchAggFactory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.fluss.server.kv.rowmerger.aggregate.factory; | ||
|
|
||
| import org.apache.fluss.metadata.AggFunction; | ||
| import org.apache.fluss.metadata.AggFunctionType; | ||
| import org.apache.fluss.server.kv.rowmerger.aggregate.functions.FieldHllSketchAgg; | ||
| import org.apache.fluss.types.DataType; | ||
| import org.apache.fluss.types.DataTypeRoot; | ||
|
|
||
| import static org.apache.fluss.utils.Preconditions.checkArgument; | ||
|
|
||
| /** Factory for {@link FieldHllSketchAgg}. */ | ||
| public class FieldHllSketchAggFactory implements FieldAggregatorFactory { | ||
|
|
||
| @Override | ||
| public FieldHllSketchAgg create(DataType fieldType, AggFunction aggFunction) { | ||
| checkArgument( | ||
| fieldType.getTypeRoot() == DataTypeRoot.BYTES, | ||
| "Data type for hll_sketch column must be 'BytesType' but was '%s'.", | ||
| fieldType); | ||
| return new FieldHllSketchAgg(fieldType); | ||
| } | ||
|
|
||
| @Override | ||
| public String identifier() { | ||
| return AggFunctionType.HLL_SKETCH.toString(); | ||
| } | ||
| } |
52 changes: 52 additions & 0 deletions
52
...main/java/org/apache/fluss/server/kv/rowmerger/aggregate/functions/FieldHllSketchAgg.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.fluss.server.kv.rowmerger.aggregate.functions; | ||
|
|
||
| import org.apache.fluss.types.DataType; | ||
|
|
||
| import org.apache.datasketches.hll.HllSketch; | ||
| import org.apache.datasketches.hll.Union; | ||
|
|
||
| /** HLL sketch aggregator for serialized Apache DataSketches HLL sketches. */ | ||
| public class FieldHllSketchAgg extends FieldAggregator { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| public FieldHllSketchAgg(DataType dataType) { | ||
| super(dataType); | ||
| } | ||
|
|
||
| @Override | ||
| public Object agg(Object accumulator, Object inputField) { | ||
| if (accumulator == null || inputField == null) { | ||
| return accumulator == null ? inputField : accumulator; | ||
| } | ||
|
|
||
| try { | ||
| HllSketch accumulatorSketch = HllSketch.heapify((byte[]) accumulator); | ||
| HllSketch inputSketch = HllSketch.heapify((byte[]) inputField); | ||
| int lgMaxK = Math.max(accumulatorSketch.getLgConfigK(), inputSketch.getLgConfigK()); | ||
| Union union = new Union(lgMaxK); | ||
| union.update(accumulatorSketch); | ||
| union.update(inputSketch); | ||
| return union.getResult().toCompactByteArray(); | ||
| } catch (RuntimeException e) { | ||
| throw new RuntimeException("Unable to deserialize or merge HLL sketch bytes.", e); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.