Repository navigation
Keep playback speed for the player session - #2016
Open
anilbeesetti wants to merge 1 commit into
Open
anilbeesetti wants to merge 1 commit into
anilbeesetti wants to merge 1 commit into
Conversation
Use the preference when creating the player and retain speed changes across videos. Remove per-video speed storage and migrate existing media state without losing other playback settings. Fixes #2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the speed of one playlist video currently affects only that video; the next video restores its saved speed or the default. Initialize playback speed from the preference when the player session starts, then retain in-player changes across videos and queue replacements until the session ends. A new session starts from the preference again.
Remove per-video playback speed from media metadata, repository APIs, and stored video state. Migrate Room from version 12 to 13, discarding saved speeds while preserving the remaining playback settings. Add regression tests for session behavior and migration data preservation.
Fixes #2015
Validation
./gradlew assembleDebug test ktlintCheck --max-workers=4passed; 296 unit tests, no failures, errors, or skips../gradlew :core:database:assembleDebugAndroidTest --max-workers=4passed.adb shell am instrument -w dev.anilbeesetti.nextplayer.core.database.test/androidx.test.runner.AndroidJUnitRunnerpassed all 13 database tests, including the new migration.