Skip to content

fix(csp): skip fence when enumerating globalThis properties #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yeapea wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(csp): skip fence when enumerating globalThis properties #4935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/csp/src/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ let globals = new Set()

Object.getOwnPropertyNames(globalThis).forEach(key => {
// Prevent Chrome and Safari deprecation warning...
if (key === "styleMedia" || key === "sharedStorage") return
if (key === "styleMedia" || key === "sharedStorage" || key === "fence") return

let value

Expand Down
20 changes: 20 additions & 0 deletions tests/vitest/csp-globals.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// @vitest-environment jsdom

import { it, expect } from 'vitest';

it('does not read the globals that browsers report as deprecated', async () => {
let read = []

for (let key of ['styleMedia', 'sharedStorage', 'fence']) {
Object.defineProperty(globalThis, key, {
configurable: true,
get() {
read.push(key)
},
})
}

await import('../../packages/csp/src/parser.js')

expect(read).toEqual([])
})
Loading