[aelmahmoudy]

This is a patch applied in Debian, I'm not sure if it applies for upstream

[aelmahmoudy]

This patch works with python3

[khaledhosny]

The CI pins Python dependencies to specific versions that I verified produce correct output. If you want to use the new glyphsets API, you will need to update the pinned version in requirements.txt. However, I strongly advice against building with any versions of the dependencies other than the pinned ones, since last time I updated them they produced a broken font and I had to revert it (d901cb3, google/fonts#9420 (comment)). Unless you are planning to debug the breakage, I suggest simply shipping the binary files I provide.

[aelmahmoudy]

Can you see if the attached fonts have that problem ? They are extracted from: http://ftp.us.debian.org/debian/pool/main/f/fonts-hosny-amiri/fonts-hosny-amiri_1.003-5_all.deb

[khaledhosny]

Can you see if the attached fonts have that problem ? They are extracted from: http://ftp.us.debian.org/debian/pool/main/f/fonts-hosny-amiri/fonts-hosny-amiri_1.003-5_all.deb

It has the kerning issue. You can easily test with hb-shape:

$ hb-shape fonts/Amiri-Regular.ttf AV
[A=0+550|V=1+623]
$ hb-shape usr/share/fonts/opentype/fonts-hosny-amiri/Amiri-Regular.ttf AV
[A=0+612|V=1+623]

The first one is the font from this repo, the second one is the font from the Debian package, notice the difference in A width due to lack of kerning in the Debian version.

[aelmahmoudy]

I hey those messages during font build: ``` incompatible second groups: <ufoLib2.objects.font.Font 'Amiri Regular' at 0x7d4919eeaf30> tries to put glyph quotedbl in group public.kern2.kc1_1, but it's already in kc0_1, discarding incompatible second groups: <ufoLib2.objects.font.Font 'Amiri Regular' at 0x7d4919eeaf30> tries to put glyph quotesingle in group public.kern2.kc1_1, but it's already in kc0_1, discarding ``` is that related to kerning issue ?

[khaledhosny]

Possibly, yes.

[bgermann]

When forwarding patches please keep the author information. I am the author.

[bgermann]

The kerning issue ist not in glyphsets. It is documented as googlefonts/ufo2ft#808 and downgrading only ufo2ft fixes the font.

[bgermann]

I have updated Debian's glyphsets to the latest Version but that does not Change the hb-shape output.