Skip to content

Highlight the Go predeclared types any and comparable #6011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nightwing merged 2 commits into from
Oct 14, 2026
Merged

Highlight the Go predeclared types any and comparable #6011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bc510b
Highlight the Go predeclared identifiers any, comparable, clear, max …
yu2971512385-ui Sep 30, 2026
e690c63
Drop the builtin functions from this change
yu2971512385-ui Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mode/golang_highlight_rules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ var oop = require("../lib/oop");
"select|type|var"
);
var builtinTypes = (
"string|uint8|uint16|uint32|uint64|int8|int16|int32|int64|float32|" +
"float64|complex64|complex128|byte|rune|uint|int|uintptr|bool|error"
"any|string|uint8|uint16|uint32|uint64|int8|int16|int32|int64|float32|" +
"float64|complex64|complex128|byte|rune|uint|int|uintptr|bool|error|comparable"
);
var builtinFunctions = (
"new|close|cap|copy|panic|panicln|print|println|len|make|delete|real|recover|imag|append"
Expand Down
10 changes: 10 additions & 0 deletions src/mode/golang_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@ module.exports = {
this.mode = new GolangMode();
},

"test: predeclared types added in Go 1.18" : function() {
var tokenizer = this.mode.getTokenizer();
function typeOf(line, index) {
return tokenizer.getLineTokens(line, "start").tokens[index].type;
}
assert.equal("support.type", typeOf("var x any", 4));
assert.equal("support.type", typeOf("type S[E comparable] int", 6));
assert.equal("support.type", typeOf("var e error", 4));
},

"test: trigger outdent if line is space and new text starts with closing brace or paren" : function() {
assert.ok(this.mode.checkOutdent("start", " ", " }"));
assert.ok(this.mode.checkOutdent("start", " ", " )"));
Expand Down
Loading