Repository navigation
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55
Fix
schema/course.schema.json: declare the course globals at_globals._components._youtube, where the template and core read them, instead of_globals._youtubemigrations/v3.js: add a migration that moves an existing flat_globals._youtubeinto_globals._components._youtube, merging with any nested values (the flat values win, as they are the ones that were edited), then removes the flat key. Courses without a flat_globals._youtubeare left unchangedTesting
src/componentsand rungrunt migration:test --file=adapt-youtube; all adapt-youtube tests pass, including the new ones (flat only; flat plus nested; nested only; no globals; plugin not installed)course.jsonhas_globals._youtube.skipToTranscriptset: the value moves to_globals._components._youtube.skipToTranscriptand_globals._youtubeis removed_globals._components._youtubevalues against the updated schema: the values are kept