Repository navigation
Fix: Name the iframe from the title text, not the heading with its completion status (fixes #53) - #54
Open
oliverfoster wants to merge 1 commit into
Open
oliverfoster wants to merge 1 commit into
oliverfoster wants to merge 1 commit into
Conversation
…mpletion status (fixes #53)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53
Fix
aria-label="{{compile_a11y_normalize displayTitle}}"(falling back totitle) instead ofaria-labelledbyon the component heading. The heading includes the screen-reader completion description, so the iframe was announced as "Incomplete. …".Testing
Accessible name of the iframe from Chrome's accessibility tree, in a built course:
displayTitle: "Intro video"displayTitle: "<b>Intro</b> video & more"titleonly