Repository navigation
Stop two errors the app logs on its own - #1950
Merged
Merged
Conversation
Quicklinks: remove the is_enabled ALTER TABLE that ran on every launch. The column has been in the schema since 2026-08-30, so SQLite logged "duplicate column name" each time. Clipboard text search: a copied file that was deleted now completes with empty text instead of failing three times and logging each failure. A file that exists but cannot be read still fails and is retried.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
None. Found while watching the Debug build's log for one minute after launch.
What changed
Two errors that Tinycast's own code wrote to the system log:
duplicate column name: is_enabledon every launch.QuicklinkStore.openDatabase()ranALTER TABLE quicklinks ADD COLUMN is_enabled …every time. The column has been in the schema since 2026-08-30, so the statement always failed and SQLite logged it. TheALTERis removed.QuicklinkTests.readsADatabaseWrittenElsewherenow writes a table that has the column; it still checks that the columns line up when the table stores them in a different order.Clipboard text extraction failedfor a deleted file. A file copied in Finder is stored as a path and read later for text search. If the file is deleted before that,ClipboardTextExtractor.extractthrew, and the item failed and was logged 3 times. NowCocoaError.fileReadNoSuchFilereturns empty text, so the item counts as a completed attempt, the same as an unsupported file. Other errors, such as a file that exists but cannot be read, still throw and are retried: permission may be given later.quicklinks.md(storage) andclipboard.md(what counts as a completed attempt).Memory footprint
Not measured. The change removes one SQLite statement and adds one
catchbranch.Leak-tested: no.
Drawbacks
is_enabledcolumn. That store will not open, and Quicklinks reports that storage is unavailable.AI usage
Claude Code read the log, found the causes, wrote the code, tests and docs, and ran the checks.
Tests & validation
mainat6f479455: Debug build after deletingbuild/DerivedData, no warnings../Scripts/lint.shclean (the 3optional_data_string_conversionwarnings it prints are already onmain). All 113 harnesses pass.ClipboardTextTests: a deleted file returns empty text, and a file in a folder with no read permission still throws.