Repository navigation
Embedded LND: v0.21.8-beta-zeus - #5729
Conversation
There was a problem hiding this comment.
Athena Review
Pinned commit: 399ae48
anthropic:claude-opus-5-5: completed openai:gpt-6-sol: completed
0 validated findings. This is a nonblocking COMMENT review, not an approval. No findings does not establish correctness.
Limitations:
- The upstream ZeusLN/lnd v0.21.8-beta-zeus release notes and changelog were not provided. Compatibility of the Lndmobile API and RPC surface with v0.21.5 could not be verified.
- The new androidSha256 and iosSha256 values could not be checked against the actual release artifacts.
- No usage of the embedded LND bindings in the Zeus codebase was supplied to check for breaking API changes.
- The new embedded LND artifacts and upstream release information were not supplied, so their checksums, API compatibility, and runtime behavior could not be verified.
Test coverage
Coverage by folderChange vs master in parentheses when nonzero.
|
|
Device tested Builds. Debug builds of this branch. Upgrade over v0.21.5-beta-zeus (PASS on both). Installed over the existing app without clearing data (
Fresh wallet (PASS on both). Created from Wallets > Add (Embedded LND, Mainnet, Bolt). Invoice and address worked.
Express Graph Sync after a reset.
Logs. No
Upstream v0.21.6 disables MPTCP listeners through a Not tested: SQLite backend, payments and channels, Tor, LSP-wrapped invoices.
|


Description
Upgrades embedded LND from
v0.21.5-beta-zeus(#5474) tov0.21.8-beta-zeus. Zeus skipped v0.21.6 and v0.21.7.Fork release: https://github.com/ZeusLN/lnd/releases/tag/v0.21.8-beta-zeus
v0.21.5-beta-zeus, rebased onto upstream lnd v0.21.8-beta (branchlnd-v0.21.8-beta-zeus). The only rebase conflicts were ingo.sum.v0.16.19-15-zeuscarries the same 7 rescan commits on top of that commit. Its go.sum hash matches sum.golang.org.godebugline in lnd's go.mod (CVE-2026-98432). gomobile writes its own go.mod and does not carry that default into the mobile libraries. Embedded LND opens no TCP listeners (in-memory gRPC,--nolisten,norest=1), so Zeus is not exposed.go build ./...and the mobile-tag build pass;go testpasses formobile,peer,lnrpc/walletrpc,lnrpc/invoicesrpc,lnwallet/btcwallet,sweep,chainntnfsandkvdb/sqlbase. All four Android ABIs and both iOS slices embedv0.21.8-beta-zeus.Protos: no change. No
.protofiles changed upstream between v0.21.5 and v0.21.8.No new sqldb or channeldb migrations (db_version stays 35), so the graph DB caps in
LndMobileToolsare unchanged.Assets downloaded from the release match the SHA-256 values in
fetch-libraries-versions.json.This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passNot run: the PR only changes
fetch-libraries-versions.jsonand a version string in a skill doc.Testing
If you modified or added testable logic, did you add new unit tests? For bug fixes, please include a test that would have caught the bug.
This PR changes a native library version, with no JS logic to unit test.
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
Results: #5729 (comment)
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
On-device
Remote
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther