Skip to content

Limit the wait for community news at launch #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Licho1 merged 2 commits into from
Nov 9, 2026
Merged

Limit the wait for community news at launch #3072

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22405ec
Limit the wait for community news at launch
moss-orbit-9f339e Nov 2, 2026
0bf807a
Run the community news query on the thread pool
moss-orbit-9f339e Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Shared/PlasmaDownloader/ChobbylaHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,21 @@ public static bool DownloadUrl(this PlasmaDownloader downloader,
}


// News is optional. Do not hold the game start when the server does not answer
// (the HttpClient default is 100 s, and Mono does not apply it to the TCP connect).
static readonly TimeSpan PublicCommunityInfoTimeout = TimeSpan.FromSeconds(10);

public static bool UpdatePublicCommunityInfo(this PlasmaDownloader downloader, IChobbylaProgress progress)
{
try
{
progress.Status = "Loading community news";
var folder = Path.Combine(downloader.SpringPaths.WritableDirectory, "news");
if (!Directory.Exists(folder)) Directory.CreateDirectory(folder);
var info = GlobalConst.GetContentService().Query(new GetPublicCommunityInfo());
// Run on the thread pool, so the query never needs the calling (UI) thread to finish.
var query = Task.Run(() => GlobalConst.GetContentService().QueryAsync(new GetPublicCommunityInfo()));
if (!query.Wait(PublicCommunityInfoTimeout)) throw new TimeoutException($"No answer from server in {PublicCommunityInfoTimeout.TotalSeconds} s");
Comment thread
Licho1 marked this conversation as resolved.
Resolved
var info = query.Result;
File.WriteAllText(Path.Combine(folder, "community.json"), JsonConvert.SerializeObject(info));
return true;
}
Expand Down
Loading