Skip to content

chore(sync): merge pingdotgg/t3code main - #343

Merged
Yarden-zamir merged 29 commits into
mainfrom
fork-sync/2026-10-25-0109
Oct 25, 2026
Merged

Yarden-zamir merged 29 commits into
mainfrom
fork-sync/2026-10-25-0109

Conversation

@Yarden-zamir

Copy link
Copy Markdown
Owner

Cause

Fork Sync run 40149330516 stopped on merge conflicts in 15 files. Upstream brought 25 commits. The ones that touch fork areas most: pingdotgg#24524 (on mobile, Settings is a workspace tab: the Settings sheet becomes root Settings pages opened with openSettings), pingdotgg#24588 (devices on the same network reach background services over LAN, privateNetworkOnly), pingdotgg#24610 (Working holds only background work the agent waits on), pingdotgg#24356 (preview navigation timeout), pingdotgg#24571 and pingdotgg#24616.

Conflicts and resolution

  • pnpm-lock.yaml: rebuilt with lockfile.py. The integrity changes equal upstream's.
  • knip.jsonc: both ignore lists (fork fonts, upstream @t3tools/mobile-highlights-native).
  • apps/server/src/serverRuntimeState.ts, apps/server/src/cli/pair.ts: upstream adds privateNetworkOnly. The fork tunnelPairingUrl stays and still comes first in resolveDirectPairingBaseUrl, before the LAN address.
  • apps/server/src/mcp/PreviewAutomationBroker.ts: the fork capture stage (forkPreviewCaptureTimeout) is spread first, and upstream's clamp of timeoutMs to the request budget after it.
  • apps/server/src/preview/ServerBrowser.test.ts: two new tests in the same place. Both stay.
  • apps/server/src/orchestration-v2/Orchestrator.ts: both imports (TurnItemId as a value, the fork thread kind imports).
  • ThreadLaunchService.ts: the fork DispatchModeLimit for agent launches stays in the dispatch pipe. Upstream's replay check (messageWasAlreadyAccepted ||= dispatched.replayed) follows it.
  • ThreadManagementService.ts: both new error classes (fork ThreadManagementTerminalThreadRefusedError, upstream ThreadManagementBackgroundWaitError).
  • apps/mobile/src/App.tsx: a fork launcher shortcut still decides the first screen on a cold start. Otherwise upstream's start URL (launchWorkspaceURL) applies.
  • apps/mobile/src/persistence/mobile-preferences.ts: the fork preference fields and upstream's workspaceSelections.
  • ConnectionsNewRouteScreen.tsx: both imports (fork client invite, upstream Settings navigation).
  • apps/mobile/src/Stack.tsx: took upstream's root Settings pages (SETTINGS_SCREENS). The fork pages SettingsFork, SettingsVoice, SettingsVoiceProject and SettingsSidebarTab are now root Settings pages there, with settings/fork, settings/voice and settings/voice/project links. Upstream moved WORKSPACE_OVERLAY_ROUTES to features/layout/workspace-overlay-routes.ts.
  • settings-sheet-targets.ts: upstream deleted it for settings-page-targets.ts. The fork targets moved to ForkSettingsPageTarget in settings-page-targets.ts, apart from SETTINGS_PAGE_TARGETS:
    • Settings does not reopen them as its remembered page, because the Voice project page needs the project that the Voice page chose.
    • Each navigation to a target union stays within the 25 members that TypeScript checks. SettingsRow navigates to a fork target in a call of its own, as in the last sync.

Fork fixes for the new Settings navigation

  • "Pair again" (forkPairAgain.ts) opens Add environment with openSettings, as upstream's home screen does.
  • The sidebar tab editor (forkSidebarTabs.ts) opens the SettingsSidebarTab root route. From the home list, it opens as a detail of the current tab, as upstream's usage account page does.
  • ForkNewTerminalThread is in the overlay route list, because it is a plain card on Android.
  • ForkUpdates.ts: a comment now says that a monitor counts as awaited only when the agent marks it (fix(threads): Working holds only background work the agent waits on pingdotgg/t3code#24610).

Upstream merge

Merges pingdotgg/t3code main at 453bf01 "fix(mobile): the iPhone new-chat button sits beside the tab bar on iOS 26.6 (pingdotgg#24492)".

Adopted upstream pull requests

All 7 entries (pingdotgg#16653, pingdotgg#16654, pingdotgg#16655, pingdotgg#16684, pingdotgg#16695, pingdotgg#16698, pingdotgg#16719) are unchanged at their listed heads. No new merges.

Upstream changes in fork areas

51 files changed on both sides. I resolved the 15 conflicts above. A separate review read the upstream diff of the other 36 files against the fork side, and found no break. It checked:

Checks

  • checks.py: typecheck, migration check and adopted pull request check pass.
  • vp fmt --check on the resolved files: clean.
  • fork_tests.py: 171 fork test files pass locally (113 root and 58 web, run with --from-chunk after the 10-minute limit). Four fork server tests next to the conflicts pass (16 tests): ThreadManagementService.fork, ThreadLaunchService.fork, PreviewAutomationBroker.fork and pair.fork. The other apps/server fork test files are left to Fork CI, because they stop the agent session on this VPS.
  • No test covers the new mobile Settings routes of the fork pages. They are navigation config, and mobile has no navigation test harness for it.

Fork repair skill changes

None. --from-chunk from #342 finished the runs that hit the 10-minute limit.

juliusmarminge and others added 29 commits October 24, 2026 16:15
…f Shiki (pingdotgg#24544)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
pingdotgg#24589)

Co-authored-by: luke2x <97411838+luke2x@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…vers (pingdotgg#24601)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ver LAN (pingdotgg#24588)

Co-authored-by: LukeCommits <dyd.lukas.real@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…empty detail (pingdotgg#24524)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… tab bar (pingdotgg#24360)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#24610)

Co-authored-by: lovelycodemonkey <ghassemimahyad@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ngdotgg#24622)

Takes over pingdotgg#23490 by Ennio Cuteri, adding a frame limit on the settle loop and reporting positioned when its target disappears.

Co-authored-by: Ennio Cuteri <ennio.cuteri@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…g#24616)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Afonso Ferreira <afonsoferreira29@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…S 26.6 (pingdotgg#24492)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…5-0109

# Conflicts:
#	apps/mobile/src/App.tsx
#	apps/mobile/src/Stack.tsx
#	apps/mobile/src/features/connection/ConnectionsNewRouteScreen.tsx
#	apps/mobile/src/features/settings/components/SettingsRow.tsx
#	apps/mobile/src/features/settings/components/settings-sheet-targets.ts
#	apps/mobile/src/persistence/mobile-preferences.ts
#	apps/server/src/cli/pair.ts
#	apps/server/src/mcp/PreviewAutomationBroker.ts
#	apps/server/src/orchestration-v2/Orchestrator.ts
#	apps/server/src/orchestration-v2/ThreadLaunchService.ts
#	apps/server/src/orchestration-v2/ThreadManagementService.ts
#	apps/server/src/preview/ServerBrowser.test.ts
#	apps/server/src/serverRuntimeState.ts
#	knip.jsonc
#	pnpm-lock.yaml
Upstream pingdotgg#24524 replaces the Settings sheet with root Settings pages.
- Pair again opens Add environment with openSettings.
- The sidebar tab editor opens the SettingsSidebarTab root route.
- The new terminal thread sheet is in the workspace overlay route list, which moved to workspace-overlay-routes.ts.
Upstream pingdotgg#24610 counts a monitor as awaited work only when the agent marks it.
@Yarden-zamir
Yarden-zamir merged commit 1bf7936 into main Oct 25, 2026
18 of 19 checks passed
@Yarden-zamir
Yarden-zamir deleted the fork-sync/2026-10-25-0109 branch October 25, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants