Repository navigation
Controls auto-hide - #1886
Draft
jamesmisson wants to merge 36 commits into
Draft
Controls auto-hide#1886jamesmisson wants to merge 36 commits into
jamesmisson wants to merge 36 commits into
Conversation
…dragonBackgroundPanel except for title render needed for CenterPanel
…title via event subscription in OpenSeadragonCenterPanel
… keep mouse interaction on center panel interactive elements
…cks in styles.less
…ic to new openPagesHandler on background panel; basic styling
…d button fields from background panel
…d nav buttons to .content
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@jamesmisson is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving this in draft until #1876 is merged, as it builds on top of that.
UI sprint issue: #1873
The panel restructure gives an opportunity to simplify the logic for the controls auto-hiding on inactivity, because the control buttons are now detached from the OSD viewer. Also, I think the auto-hide conditions had become confused and broken at some point so this needs some attention anyway.
This restores the feature in a simpler form, and starts with some basic behavior that we can expand on if necessary. In this PR:
autoHideControlsis true, the image control buttons, nav buttons, and OSD navigator fade out after inactivitycontrolsFadeAfterInactive, as beforecontrolsFadeLength, as before