Repository navigation
Conversation
The Command component (cmdk) defaults its keyboard-navigation highlight to the first item. Pass the currently selected connection ID as the Command value so the highlight lands on the correct item when the dropdown opens. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
The connection selector’s controlled active value lacks an onValueChange handler, preventing keyboard and hover navigation from updating the highlight and causing Enter to select the original connection.
1 open issue
What changed in this PR
This PR aims to make the Chat Settings connections picker initially highlight the active connection instead of the first item.
Changes:
- Passes the selected connection ID to cmdk’s
Commandvalue, falling back to an empty string when no connection is selected.
| File | Description |
|---|---|
packages/conversational-agent-chat/src/components/SettingsDialog/ConnectionsSection.tsx |
Binds the picker’s active-item value to the selected connection ID. |
Review effort: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
The picker fix lacks a regression test with a non-first active connection to verify that only the active option is highlighted on opening and arrow-key navigation starts from it.
1 open issue
1 resolved since last review
Review effort: Balanced
Contributor
📊 Coverage Report
|
andrewwan-uipath
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commandcomponent (cmdk) defaults its keyboard-navigation highlight to the first item in the list. When opening the connections dropdown, this caused the wrong connection to appear selected (e.g. the first shared connection instead of the user's active connection).defaultValue={selectedId}toCommandso the highlight starts on the currently selected connection.Before:
After:
Test plan
🤖 Generated with Claude Code