Skip to content

Fix libcxx build - #2194

Open
aokblast wants to merge 1 commit into
TigerVNC:masterfrom
aokblast:fix_cxx_build
Open

aokblast wants to merge 1 commit into
TigerVNC:masterfrom
aokblast:fix_cxx_build

Conversation

@aokblast

@aokblast aokblast commented Nov 7, 2026

Copy link
Copy Markdown
  1. Using malloc, free but doesn't include stdlib.h
  2. Using std::bad_alloc but doesn't include new
  3. Using exit but doesn't include stdlib.h
  4. Using errno but doesn't include errno.h

1. Using malloc, free but doesn't include stdlib.h
2. Using std::bad_alloc but doesn't include new
3. Using exit but doesn't include stdlib.h
4. Using errno but doesn't include errno.h
@CendioOssman

Copy link
Copy Markdown
Member

The changes look theoretically reasonable, but I'm not understanding the connection to libcxx? Under what conditions are you getting issues here?

@aokblast

aokblast commented Nov 9, 2026

Copy link
Copy Markdown
Author

The changes look theoretically reasonable, but I'm not understanding the connection to libcxx? Under what conditions are you getting issues here?

I am unable to build. It only happens on libcxx (llvm's standard C++ implementation). libstdcxx (GNU's implementation) seems include those headers by other header. This is why it doesn't trigger on libstdcxx and why I mention libcxx in here.

@CendioOssman

Copy link
Copy Markdown
Member

I see. I'm not getting those builds on macOS, though, where libcxx should be used. What platform are you testing on?

@aokblast

Copy link
Copy Markdown
Author

I see. I'm not getting those builds on macOS, though, where libcxx should be used. What platform are you testing on?

I tested this on my customized Gentoo Linux build with libcxx23. This also not happen before libcxx23 (I think they delete some include header). MacOS doesn't happen for now as they haven't ship libcxx 23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants