Skip to content

Design a recycling bin system #2629

Closed
Closed

Description

@EmmanuelMess

Describe the bug

  • Where would it be?
  • How are files deleted?
  • How are files restored?
  • How are users differentiated?
  • How hidden is the store of files?
  • Can the storage of deleted files be accessed from other file managers?
  • Does the storage of deleted files have a size limit?
  • How is metadata kept?
  • Is it enabled by default?

Activity

  1. EmmanuelMess commented on Jun 15, 2021

    @EmmanuelMess
    MemberAuthor

    If the user swaps sd cards the files should stay in the sd card otherwise it might create a weird situation where the files are on the phone, but the sd card is not connected.
    To keep track of the user id we can use a ".Trash-" format, like Ubuntu.
    To keep track of metadata we can use a separate plain text file, like Ubuntu.

  2. VishalNehra commented on Jun 15, 2021

    @VishalNehra
    Member

    @EmmanuelMess Remind me again why we need metadata file.

  3. EmmanuelMess commented on Jun 15, 2021

    @EmmanuelMess
    MemberAuthor

    Remind me again why we need metadata file.

    Some metadata gets modified on move afaik (like timestamps), and the need to save the restoration location.

  4. VishalNehra commented on Jun 15, 2021

    @VishalNehra
    Member

    @EmmanuelMess Right correct - for restoration location. How about actually preserving last modified for move operation?

  5. EmmanuelMess commented on Jun 15, 2021

    @EmmanuelMess
    MemberAuthor

    Right correct - for restoration location. How about actually preserving last modified for move operation?

    The operation restore must revert all changes from the delete. As the delete operation does a move all changes made by the move must be undone by restore. That includes some timestamps.

  6. VishalNehra commented on Jun 15, 2021

    @VishalNehra
    Member

    @EmmanuelMess Yes. That's why I mentioned we should preserve created and modified date with move operation to begin with. I'm not sure what other timestamps you are referring to.
    Maintaining more fields other than restore location should make sense, but I'll leave it upto the person who does the POC.

  7. EmmanuelMess commented on Jun 15, 2021

    @EmmanuelMess
    MemberAuthor

    Yes. That's why I mentioned we should preserve created and modified date with move operation to begin with. I'm not sure what other timestamps you are referring to.

    Ah, I misunderstood then. Anyways, a test for the entire metadata should be written, so that we know nothing failed weirdly.

    Maintaining more fields other than restore location should make sense, but I'll leave it upto the person who does the POC.

    That is a good idea

  8. locked and limited conversation to collaborators on Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-DiscussionDeprecated: use discussions tab.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions