Skip to content

Use shared breadcrumbs on bespoke partner pages - #1464

Merged
tannerlinsley merged 3 commits into
mainfrom
taren/bespoke-partner-breadcrumbs
Nov 1, 2026
Merged

tannerlinsley merged 3 commits into
mainfrom
taren/bespoke-partner-breadcrumbs

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Railway, Render and Netlify have their own partner pages, so the generic partner breadcrumb change does not reach them. Use the same semantic breadcrumb component and shared item model on those pages, including the matching WebPage BreadcrumbList.

Continues #1151 following merged #1463. Existing partner content, referral destinations and FAQ structured data are preserved. The umbrella issue stays open for the remaining library, chart and docs coverage.

Validation: full pnpm test through normal commit hooks. The shared component and model were independently checked in SSR and desktop/mobile browser fixtures in #1463. All three exact-commit deployed previews passed SSR checks for canonical breadcrumbs and retained FAQ data. Railway and Render were visually checked at desktop width, Netlify at 375px with no horizontal overflow. The subsequent main integration has an identical tree, verified by an empty diff, and passed full normal commit hooks again. Exact-head CI remains required before merge.

Summary by CodeRabbit

  • Improvements
    • Partner pages for Netlify, Railway, and Render now use consistent breadcrumb navigation.
    • Breadcrumb information is included in structured data on these pages.

@changeset-bot

changeset-bot Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f45490d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7a443b86-7dbe-4f77-8ae6-4b14a4d4395d
Commits

Reviewing files that changed from the base of the PR and between fed7820 and f45490d.

Files selected for processing: 3
  • src/routes/partners.netlify.tsx
  • src/routes/partners.railway.tsx
  • src/routes/partners.render.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Walkthrough

The Netlify, Railway, and Render partner routes now use shared breadcrumb navigation and include breadcrumb structured data in their JSON-LD output.

Changes: Partner breadcrumbs

Layer / File(s) Summary
Partner route breadcrumb integration
src/routes/partners.netlify.tsx, src/routes/partners.railway.tsx, src/routes/partners.render.tsx
The three routes replace inline partner navigation with the shared Breadcrumbs component. Each route adds breadcrumb structured data alongside its existing partner JSON-LD. Netlify uses a fallback partner when partner data is unavailable.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: jhislop-design

Merge Risk: Minimal · up to f4549

The breadcrumb integration introduces no established merge-blocking correctness, availability, or data-integrity risk.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: applying shared breadcrumbs to bespoke partner pages.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 3 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Base automatically changed from taren/partner-breadcrumbs to main November 1, 2026 01:54
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com f45490d Commit Preview URL

Branch Preview URL
Nov 01 2026, 01:58 AM

@tannerlinsley
tannerlinsley merged commit 483b653 into main Nov 1, 2026
8 checks passed
@tannerlinsley
tannerlinsley deleted the taren/bespoke-partner-breadcrumbs branch November 1, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant