[YuKongA]

Keep Make variable reads raw and handle strings, scalars and booleans at their consumers.

Share generated C flags across recovery, GUI, minui and MTP, and remove double stringification of string macros. Fix the custom LUN macro mapping and handle unset optional storage paths.

Link libtar statically with recovery to resolve FBE callbacks against the same libvold state. Replace invalid kernel header dependencies and add regression tests.

Fixed #33

[Copilot]

🔵 Needs a closer look

The cross-layer Make/Soong propagation and static FBE linkage require full-tree build validation.

0 open findings

What changed in this PR

Fixes #33 by preserving raw Make values and converting them according to their consumers.

Changes:

• Adds typed handling for strings, scalars, booleans, and integers.
• Shares generated flags across recovery, GUI, minui, and MTP.
• Statically links libtar and adds regression coverage.

File	Description
Android.bp	Registers shared flags, tests, and static libtar linkage.
data.cpp	Consumes typed macros directly.
gui/​Android.bp	Applies shared flags to GUI.
gui/​libtwrpgui_defaults.go	Uses typed Make-variable accessors.
libtar/​Android.bp	Retains only the static libtar target.
libtar/​libtar_defaults.go	Normalizes boolean and policy variables.
mtp/​Android.bp	Applies shared flags to MTP.
mtp/​twrp/​TwrpMtpServer.cpp	Uses the MTP device string directly.
partition.cpp	Uses string macros and handles an unset external path.
prebuilt/​Android.mk	Normalizes quoted boolean conditions.
soong/​makevars.go	Preserves raw vendor values.
soong/​tests/​test_variables.py	Adds end-to-end Make/Go/C++ regressions.
soong/​variables.go	Adds typed value and literal conversion helpers.
soong/​variables_test.go	Tests conversion edge cases.
twrp.cpp	Uses the battery path string directly.
twrp_apex.cpp	Uses the APEX file-list string directly.
twrp_defaults_test.go	Tests shared flag propagation.
twrp_flags.go	Centralizes generated C flags.
twrp_flags_test.go	Tests flag generation and compiler semantics.
twrp_recovery_defaults.go	Separates reusable flags from recovery defaults.
twrpminui/​Android.bp	Applies shared flags to minui.
twrpminui/​events.cpp	Removes redundant macro stringification.
twrpminui/​libtwrpminui_defaults.go	Uses typed variables and proper kernel headers.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.