Repository navigation
Conversation
GoogleWTS._load_cache checked that the cache directory was missing and then made it, so a process that lost the race to another one raised FileExistsError. Make the directory and treat an existing one as made, so only the process that made it warns. Closes SciTools#2782
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Closes #2782. Replaces #2783 (see the comment there).
GoogleWTS._load_cachechecked that the cache directory was missing and then made it, so a process that lost the race to another one raisedFileExistsError. This makes the directory and treats an existing one as already made. Unlikeexist_ok=True, only the process that actually made the directory gives the "Cartopy created the following directory" warning.Implications
None for a single process. The new test runs without the network: it makes the directory appear just before
mkdir, and checks that no error or warning comes out.I used Claude Code (an AI coding agent) for this change; I directed it and reviewed the diff.